You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "hvanhovell (via GitHub)" <gi...@apache.org> on 2024/09/04 17:17:03 UTC
[PR] [SPARK-49284][CONNECT][SQL] Create a shared Catalog interface [spark]
hvanhovell opened a new pull request, #47991:
URL: https://github.com/apache/spark/pull/47991
### What changes were proposed in this pull request?
This PR creates a shared Catalog interface. We also move the interfaces to sql/api.
### Why are the changes needed?
We are creating a shared Scala Spark SQL interface for Classic and Connect.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Existing tests.
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49284][CONNECT][SQL] Create a shared Catalog interface [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #47991:
URL: https://github.com/apache/spark/pull/47991#issuecomment-2333576365
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49284][CONNECT][SQL] Create a shared Catalog interface [spark]
Posted by "xinrong-meng (via GitHub)" <gi...@apache.org>.
xinrong-meng commented on PR #47991:
URL: https://github.com/apache/spark/pull/47991#issuecomment-2330556018
LGTM thank you!
btw ClientStreamingQuerySuite and FlatMapGroupsWithStateStreamingSuite seem flaky and also fail in my PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49284][CONNECT][SQL] Create a shared Catalog interface [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #47991:
URL: https://github.com/apache/spark/pull/47991#issuecomment-2330653431
@HyukjinKwon Have there been any major changes to the startup process of the connect-server recently? I've noticed that it has frequently failed to start during recent GA tests, such as the current pr:
- https://github.com/hvanhovell/spark/actions/runs/10706361897/job/29683945623
<img width="1149" alt="image" src="https://github.com/user-attachments/assets/771c4097-a105-4817-8a73-f11b0a874876">
and other cases:
- https://github.com/TongWei1105/spark/actions/runs/10713505479/job/29705646577
- https://github.com/liujiayi771/spark/actions/runs/10712981038/job/29704300464
- https://github.com/hvanhovell/spark/actions/runs/10712663831/job/29703447623
and daily tests:
- https://github.com/apache/spark/actions/runs/10694846297/job/29647315383
- https://github.com/apache/spark/actions/runs/10702260700/job/29670054329
- https://github.com/apache/spark/actions/runs/10693497231/job/29643754734
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49284][CONNECT][SQL] Create a shared Catalog interface [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #47991:
URL: https://github.com/apache/spark/pull/47991#issuecomment-2330689186
Yeah, https://github.com/apache/spark/pull/47994 should fix it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49284][CONNECT][SQL] Create a shared Catalog interface [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #47991: [SPARK-49284][CONNECT][SQL] Create a shared Catalog interface
URL: https://github.com/apache/spark/pull/47991
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org