You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Michael McCandless (JIRA)" <ji...@apache.org> on 2013/06/06 02:22:20 UTC

[jira] [Commented] (LUCENE-5033) SlowFuzzyQuery appears to fail with edit distance >=3 in some cases

    [ https://issues.apache.org/jira/browse/LUCENE-5033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13676532#comment-13676532 ] 

Michael McCandless commented on LUCENE-5033:
--------------------------------------------

Thanks Tim!  This looks like a great improvement: I like factoring out calcDistance from calcSimilarity.

And I like that we now take raw into account when figuring out which comparison to make to accept the term or not.  Maybe we could improve it a bit: if raw is true we don't need to calcSimilarity right?

For my sanity ... where exactly was the bug in the original code?
                
> SlowFuzzyQuery appears to fail with edit distance >=3 in some cases
> -------------------------------------------------------------------
>
>                 Key: LUCENE-5033
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5033
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: modules/other
>    Affects Versions: 4.3
>            Reporter: Tim Allison
>            Priority: Minor
>         Attachments: LUCENE-5033.patch
>
>
> Levenshtein edit btwn "monday" and "montugu" should be 4.  The following shows a query with "sim" set to 3, and there is a hit.
>   public void testFuzzinessLong2() throws Exception {
>      Directory directory = newDirectory();
>      RandomIndexWriter writer = new RandomIndexWriter(random(), directory);
>      addDoc("monday", writer);
>      
>      IndexReader reader = writer.getReader();
>      IndexSearcher searcher = newSearcher(reader);
>      writer.close();
>      SlowFuzzyQuery query;
>      query = new SlowFuzzyQuery(new Term("field", "montugu"), 3, 0);   
>      ScoreDoc[] hits = searcher.search(query, null, 1000).scoreDocs;
>      assertEquals(0, hits.length);
>   }

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org