You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "laglangyue (via GitHub)" <gi...@apache.org> on 2024/04/06 06:33:06 UTC
[PR] enable GrpcInteropIoWithPekkoHttpJavaSpec to work [pekko-grpc]
laglangyue opened a new pull request, #257:
URL: https://github.com/apache/pekko-grpc/pull/257
close #204
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] enable GrpcInteropIoWithPekkoHttpJavaSpec to work [pekko-grpc]
Posted by "laglangyue (via GitHub)" <gi...@apache.org>.
laglangyue commented on code in PR #257:
URL: https://github.com/apache/pekko-grpc/pull/257#discussion_r1554806997
##########
interop-tests/src/test/java/org/apache/pekko/grpc/interop/PekkoGrpcJavaClientTester.java:
##########
@@ -34,49 +35,72 @@
import io.grpc.testing.integration.UnimplementedServiceClient;
import io.grpc.testing.integration2.ClientTester;
import io.grpc.testing.integration2.Settings;
-import org.junit.Assert;
-import scala.concurrent.ExecutionContext;
import java.io.InputStream;
+
import java.util.ArrayList;
import java.util.List;
import java.util.Optional;
import java.util.concurrent.CompletionStage;
import java.util.concurrent.TimeUnit;
+import java.security.KeyManagementException;
+import java.security.NoSuchAlgorithmException;
+import javax.net.ssl.SSLContext;
+import javax.net.ssl.TrustManager;
+
+import scala.concurrent.ExecutionContext;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.fail;
/**
* ClientTester implementation that uses the generated pekko-grpc Java client to exercise a server under test.
- *
+ * <p>
Review Comment:
thanks.
Since pekko grpc did not use Javafmt before, I used idea formatting, which usually recommends adding <p> on empty lines
I have reformatted by javafmt and converted it, but it has not been pushed yet, I am testing the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] enable GrpcInteropIoWithPekkoHttpJavaSpec to work [pekko-grpc]
Posted by "Roiocam (via GitHub)" <gi...@apache.org>.
Roiocam merged PR #257:
URL: https://github.com/apache/pekko-grpc/pull/257
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] enable GrpcInteropIoWithPekkoHttpJavaSpec to work [pekko-grpc]
Posted by "samueleresca (via GitHub)" <gi...@apache.org>.
samueleresca commented on code in PR #257:
URL: https://github.com/apache/pekko-grpc/pull/257#discussion_r1554630116
##########
interop-tests/src/test/java/org/apache/pekko/grpc/interop/PekkoGrpcJavaClientTester.java:
##########
@@ -34,49 +35,72 @@
import io.grpc.testing.integration.UnimplementedServiceClient;
import io.grpc.testing.integration2.ClientTester;
import io.grpc.testing.integration2.Settings;
-import org.junit.Assert;
-import scala.concurrent.ExecutionContext;
import java.io.InputStream;
+
import java.util.ArrayList;
import java.util.List;
import java.util.Optional;
import java.util.concurrent.CompletionStage;
import java.util.concurrent.TimeUnit;
+import java.security.KeyManagementException;
+import java.security.NoSuchAlgorithmException;
+import javax.net.ssl.SSLContext;
+import javax.net.ssl.TrustManager;
+
+import scala.concurrent.ExecutionContext;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.fail;
/**
* ClientTester implementation that uses the generated pekko-grpc Java client to exercise a server under test.
- *
+ * <p>
Review Comment:
minor: is this needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] enable GrpcInteropIoWithPekkoHttpJavaSpec to work [pekko-grpc]
Posted by "laglangyue (via GitHub)" <gi...@apache.org>.
laglangyue commented on PR #257:
URL: https://github.com/apache/pekko-grpc/pull/257#issuecomment-2041295452
I rebase and format the code by javafmt.
The previous CI failure was due to OOM, test it OK on my PC
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org