[GitHub] [incubator-mxnet] bgawrych commented on a change in pull request #20474: [FEATURE] Enable dynamic linking with MKL and compiler based OpenMP

[GitBox <gi...@apache.org>]

bgawrych commented on a change in pull request #20474:
URL: https://github.com/apache/incubator-mxnet/pull/20474#discussion_r693905429



##########
File path: cmake/ChooseBlas.cmake
##########
@@ -155,14 +164,19 @@ elseif(BLAS STREQUAL "MKL" OR BLAS STREQUAL "mkl")
     endif()
   endif()
   # Setting up BLAS_mkl_MKLROOT for non-Ubuntu 20.04 OSes
-  find_path(BLAS_mkl_MKLROOT mkl PATHS $ENV{MKLROOT} ${INTEL_HOME_ROOT} ${INTEL_OPT_ROOT})

Review comment:
       Same line not changed in: https://github.com/apache/incubator-mxnet/pull/20474/files#R27
   Is it done on purpose or just missed?

##########
File path: src/initialize.cc
##########
@@ -93,6 +95,24 @@ LibraryInitializer::LibraryInitializer()
     cpu_worker_nthreads_(dmlc::GetEnv("MXNET_CPU_WORKER_NTHREADS", 1)),
     mp_cv_num_threads_(dmlc::GetEnv("MXNET_MP_OPENCV_NUM_THREADS", 0)) {
   dmlc::InitLogging("mxnet");
+
+#if !(defined(_WIN32) || defined(_WIN64) || defined(__WINDOWS__))

Review comment:
       maybe it should be moved to a function like install_pthread_atfork_handlers - it probably will be more descriptive on what's happening here




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org