[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #235: Write to hdfs when local disk can't be write

[GitBox <gi...@apache.org>]

jerqi commented on code in PR #235:
URL: https://github.com/apache/incubator-uniffle/pull/235#discussion_r976386898


##########
server/src/main/java/org/apache/uniffle/server/storage/MultiStorageManager.java:
##########
@@ -96,7 +96,15 @@ private StorageManager selectStorageManager(ShuffleDataFlushEvent event) {
     if (event.getSize() > flushColdStorageThresholdSize) {
       return coldStorageManager;
     } else {
-      return warmStorageManager;
+      try {

Review Comment:
   What will happen when both the cold storage manager and warm storage manager are broken? It seems to fall back many times.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org