You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2016/08/13 00:41:19 UTC
[kudu-CR] Add regex string match assert helper macros
Mike Percy has uploaded a new change for review.
http://gerrit.cloudera.org:8080/3962
Change subject: Add regex string match assert helper macros
......................................................................
Add regex string match assert helper macros
Change-Id: I05d869479f4032d584a83b455979073c7707d9e7
---
M src/kudu/util/test_macros.h
1 file changed, 54 insertions(+), 23 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/62/3962/1
--
To view, visit http://gerrit.cloudera.org:8080/3962
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I05d869479f4032d584a83b455979073c7707d9e7
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
[kudu-CR] Add regex string match assert helper macros
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: Add regex string match assert helper macros
......................................................................
Patch Set 1:
Build Started http://104.196.14.100/job/kudu-gerrit/2851/
--
To view, visit http://gerrit.cloudera.org:8080/3962
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I05d869479f4032d584a83b455979073c7707d9e7
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] Add regex string match assert helper macros
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3962
to look at the new patch set (#2).
Change subject: Add regex string match assert helper macros
......................................................................
Add regex string match assert helper macros
These delegate to gmock but are easier to remember than:
ASSERT_THAT(str, testing::ContainsRegex(pattern))
Change-Id: I05d869479f4032d584a83b455979073c7707d9e7
---
M src/kudu/util/test_macros.h
1 file changed, 41 insertions(+), 23 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/62/3962/2
--
To view, visit http://gerrit.cloudera.org:8080/3962
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I05d869479f4032d584a83b455979073c7707d9e7
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Add regex string match assert helper macros
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged.
Change subject: Add regex string match assert helper macros
......................................................................
Add regex string match assert helper macros
These delegate to gmock but are easier to remember than:
ASSERT_THAT(str, testing::ContainsRegex(pattern))
Change-Id: I05d869479f4032d584a83b455979073c7707d9e7
Reviewed-on: http://gerrit.cloudera.org:8080/3962
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M src/kudu/util/test_macros.h
1 file changed, 41 insertions(+), 23 deletions(-)
Approvals:
Todd Lipcon: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/3962
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I05d869479f4032d584a83b455979073c7707d9e7
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Add regex string match assert helper macros
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: Add regex string match assert helper macros
......................................................................
Patch Set 2:
Build Started http://104.196.14.100/job/kudu-gerrit/2852/
--
To view, visit http://gerrit.cloudera.org:8080/3962
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I05d869479f4032d584a83b455979073c7707d9e7
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Add regex string match assert helper macros
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3962
to look at the new patch set (#3).
Change subject: Add regex string match assert helper macros
......................................................................
Add regex string match assert helper macros
These delegate to gmock but are easier to remember than:
ASSERT_THAT(str, testing::ContainsRegex(pattern))
Change-Id: I05d869479f4032d584a83b455979073c7707d9e7
---
M src/kudu/util/test_macros.h
1 file changed, 41 insertions(+), 23 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/62/3962/3
--
To view, visit http://gerrit.cloudera.org:8080/3962
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I05d869479f4032d584a83b455979073c7707d9e7
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Add regex string match assert helper macros
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: Add regex string match assert helper macros
......................................................................
Patch Set 3:
Build Started http://104.196.14.100/job/kudu-gerrit/2854/
--
To view, visit http://gerrit.cloudera.org:8080/3962
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I05d869479f4032d584a83b455979073c7707d9e7
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Add regex string match assert helper macros
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: Add regex string match assert helper macros
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3962
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I05d869479f4032d584a83b455979073c7707d9e7
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Add regex string match assert helper macros
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: Add regex string match assert helper macros
......................................................................
Patch Set 1:
I think this same functionality is already available using the ContainsRegex or MatchesRegex matcher from gmock?
--
To view, visit http://gerrit.cloudera.org:8080/3962
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I05d869479f4032d584a83b455979073c7707d9e7
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No