You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Kengo Seki (JIRA)" <ji...@apache.org> on 2015/09/03 17:35:45 UTC
[jira] [Updated] (HADOOP-12312) Findbugs HTML report link shows 0
warnings despite errors
[ https://issues.apache.org/jira/browse/HADOOP-12312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kengo Seki updated HADOOP-12312:
--------------------------------
Attachment: Screen Shot 2015-09-04 at 00.25.44.png
HADOOP-12312.HADOOP-12111.00.patch
Attaching a patch. Abbreviated console output is as follows:
{code}
[sekikn@mobile hadoop]$ dev-support/test-patch.sh --basedir=../dev/hadoop --project=hadoop https://issues.apache.org/jira/secure/attachment/12751537/hadoop-reproduciable.git2c4208f.patch
(snip)
| Vote | Subsystem | Runtime | Comment
============================================================================
| -1 | findbugs | 2m 53s | hadoop-common-project/hadoop-common
| | | | introduced 2 new FindBugs issues.
Reason | Tests
FindBugs | module:hadoop-common-project/hadoop-common
| Found reliance on default encoding in org.apache.hadoop.metrics2.sink.KafkaSink.putMetrics(MetricsRecord):in org.apache.hadoop.metrics2.sink.KafkaSink.putMetrics(MetricsRecord): String.getBytes() At KafkaSink.java:[line 135]
| org.apache.hadoop.metrics2.sink.KafkaSink.putMetrics(MetricsRecord) invokes inefficient new String(String) constructor At KafkaSink.java:constructor At KafkaSink.java:[line 96]
|| Subsystem || Report/Notes ||
============================================================================
| findbugs | v3.0.0 |
| findbugs | /private/tmp/test-patch-hadoop/58204/new-findbugs-hadoop-common-project_hadoop-common.html |
{code}
The screenshot of new-findbugs-hadoop-common-project_hadoop-common.html is also attached. It displays the correct information.
> Findbugs HTML report link shows 0 warnings despite errors
> ---------------------------------------------------------
>
> Key: HADOOP-12312
> URL: https://issues.apache.org/jira/browse/HADOOP-12312
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: yetus
> Affects Versions: HADOOP-12111
> Reporter: Varun Saxena
> Assignee: Kengo Seki
> Attachments: HADOOP-12312.HADOOP-12111.00.patch, Screen Shot 2015-09-04 at 00.25.44.png, hadoop-reproduciable.git2c4208f.patch
>
>
> Refer to Hadoop QA report below :
> https://issues.apache.org/jira/browse/YARN-3232?focusedCommentId=14679146&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14679146
> The report shows -1 for findbugs because there have been 7 findbugs warnings introduced. But the HTML report in link is showing 0 findbugs warnings.
> I verified locally and the warnings did indeed exist.
> So there must be some problem in findbugs HTML report generation in test-patch.sh
> This inconsistency between -1 for findbugs and HTML report lead to these findbugs warnings being leaked to trunk.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)