[GitHub] [dolphinscheduler] SbloodyS commented on a diff in pull request #11120: [Fix-10918] Close datasource when expire from guava cache

[GitBox <gi...@apache.org>]

SbloodyS commented on code in PR #11120:
URL: https://github.com/apache/dolphinscheduler/pull/11120#discussion_r928099027


##########
dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-api/src/main/java/org/apache/dolphinscheduler/plugin/datasource/api/plugin/DataSourceClientProvider.java:
##########
@@ -61,7 +68,7 @@ public static DataSourceClientProvider getInstance() {
     public Connection getConnection(DbType dbType, ConnectionParam connectionParam) throws ExecutionException {
         BaseConnectionParam baseConnectionParam = (BaseConnectionParam) connectionParam;
         String datasourceUniqueId = DataSourceUtils.getDatasourceUniqueId(baseConnectionParam, dbType);
-        logger.info("getConnection datasourceUniqueId {}", datasourceUniqueId);
+        logger.info("Get connection form datasource {}", datasourceUniqueId);

Review Comment:
   ```suggestion
           logger.info("Get connection from datasource {}", datasourceUniqueId);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org