You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Madhan Neethiraj <ma...@apache.org> on 2023/10/19 03:49:50 UTC

Review Request 74683: made security-zones for the resource available in the request context

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74683/
-----------------------------------------------------------

Review request for ranger, Ankita Sinha, Abhay Kulkarni, Ramesh Mani, and Subhrat Chaudhary.


Bugs: RANGER-4484
    https://issues.apache.org/jira/browse/RANGER-4484


Repository: ranger


Description
-------

- updated RangerDefaultRequestProcessor.preProcess() to compute security-zones for the accessed resource and store in context
- updated policy evaluation paths to obtain security-zone from the context, instead of computing


Diffs
-----

  agents-common/src/main/java/org/apache/ranger/plugin/policyengine/PolicyEngine.java 3373dbae9 
  agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java fd78fd8e0 
  agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerRequestScriptEvaluator.java 0df8686e3 
  agents-common/src/main/java/org/apache/ranger/plugin/service/RangerDefaultRequestProcessor.java 6fa75d602 
  agents-common/src/main/java/org/apache/ranger/plugin/util/RangerAccessRequestUtil.java b505f495b 
  security-admin/src/main/java/org/apache/ranger/biz/RangerPolicyAdminImpl.java 6799be200 


Diff: https://reviews.apache.org/r/74683/diff/1/


Testing
-------

- verified that all tests pass successfully


Thanks,

Madhan Neethiraj


Re: Review Request 74683: RANGER-4484: made security-zones for the resource available in the request context

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74683/
-----------------------------------------------------------

(Updated Oct. 19, 2023, 6:31 a.m.)


Review request for ranger, Ankita Sinha, Abhay Kulkarni, Ramesh Mani, and Subhrat Chaudhary.


Changes
-------

addressed the review comment


Bugs: RANGER-4484
    https://issues.apache.org/jira/browse/RANGER-4484


Repository: ranger


Description
-------

- updated RangerDefaultRequestProcessor.preProcess() to compute security-zones for the accessed resource and store in context
- updated policy evaluation paths to obtain security-zone from the context, instead of computing


Diffs (updated)
-----

  agents-common/src/main/java/org/apache/ranger/plugin/policyengine/PolicyEngine.java 3373dbae9 
  agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java fd78fd8e0 
  agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerRequestScriptEvaluator.java 0df8686e3 
  agents-common/src/main/java/org/apache/ranger/plugin/service/RangerDefaultRequestProcessor.java 6fa75d602 
  agents-common/src/main/java/org/apache/ranger/plugin/util/RangerAccessRequestUtil.java b505f495b 
  security-admin/src/main/java/org/apache/ranger/biz/RangerPolicyAdminImpl.java 6799be200 


Diff: https://reviews.apache.org/r/74683/diff/2/

Changes: https://reviews.apache.org/r/74683/diff/1-2/


Testing
-------

- verified that all tests pass successfully


Thanks,

Madhan Neethiraj


Re: Review Request 74683: RANGER-4484: made security-zones for the resource available in the request context

Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74683/#review225875
-----------------------------------------------------------




agents-common/src/main/java/org/apache/ranger/plugin/util/RangerAccessRequestUtil.java
Lines 278 (patched)
<https://reviews.apache.org/r/74683/#comment314286>

    Nit pick: No need of null check, instanceof should be enough.


- Ramesh Mani


On Oct. 19, 2023, 3:49 a.m., Madhan Neethiraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74683/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2023, 3:49 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Abhay Kulkarni, Ramesh Mani, and Subhrat Chaudhary.
> 
> 
> Bugs: RANGER-4484
>     https://issues.apache.org/jira/browse/RANGER-4484
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> - updated RangerDefaultRequestProcessor.preProcess() to compute security-zones for the accessed resource and store in context
> - updated policy evaluation paths to obtain security-zone from the context, instead of computing
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/policyengine/PolicyEngine.java 3373dbae9 
>   agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java fd78fd8e0 
>   agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerRequestScriptEvaluator.java 0df8686e3 
>   agents-common/src/main/java/org/apache/ranger/plugin/service/RangerDefaultRequestProcessor.java 6fa75d602 
>   agents-common/src/main/java/org/apache/ranger/plugin/util/RangerAccessRequestUtil.java b505f495b 
>   security-admin/src/main/java/org/apache/ranger/biz/RangerPolicyAdminImpl.java 6799be200 
> 
> 
> Diff: https://reviews.apache.org/r/74683/diff/1/
> 
> 
> Testing
> -------
> 
> - verified that all tests pass successfully
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>


Re: Review Request 74683: RANGER-4484: made security-zones for the resource available in the request context

Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74683/#review225876
-----------------------------------------------------------


Ship it!




Ship It!

- Ramesh Mani


On Oct. 19, 2023, 3:49 a.m., Madhan Neethiraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74683/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2023, 3:49 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Abhay Kulkarni, Ramesh Mani, and Subhrat Chaudhary.
> 
> 
> Bugs: RANGER-4484
>     https://issues.apache.org/jira/browse/RANGER-4484
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> - updated RangerDefaultRequestProcessor.preProcess() to compute security-zones for the accessed resource and store in context
> - updated policy evaluation paths to obtain security-zone from the context, instead of computing
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/policyengine/PolicyEngine.java 3373dbae9 
>   agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java fd78fd8e0 
>   agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerRequestScriptEvaluator.java 0df8686e3 
>   agents-common/src/main/java/org/apache/ranger/plugin/service/RangerDefaultRequestProcessor.java 6fa75d602 
>   agents-common/src/main/java/org/apache/ranger/plugin/util/RangerAccessRequestUtil.java b505f495b 
>   security-admin/src/main/java/org/apache/ranger/biz/RangerPolicyAdminImpl.java 6799be200 
> 
> 
> Diff: https://reviews.apache.org/r/74683/diff/1/
> 
> 
> Testing
> -------
> 
> - verified that all tests pass successfully
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>