You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/06/22 20:25:44 UTC
[GitHub] [geode] sabbeyPivotal opened a new pull request #5282: GEODE-8288: Match Native Redis's glob-style pattern
sabbeyPivotal opened a new pull request #5282:
URL: https://github.com/apache/geode/pull/5282
Native Redis has their own glob-style pattern (https://redis.io/commands/keys). Change our implementation to that of Native Redis
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] jdeppe-pivotal merged pull request #5282: GEODE-8288: Match Redis's glob-style pattern
Posted by GitBox <gi...@apache.org>.
jdeppe-pivotal merged pull request #5282:
URL: https://github.com/apache/geode/pull/5282
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] dschneider-pivotal commented on a change in pull request #5282: GEODE-8288: Match Redis's glob-style pattern
Posted by GitBox <gi...@apache.org>.
dschneider-pivotal commented on a change in pull request #5282:
URL: https://github.com/apache/geode/pull/5282#discussion_r444730179
##########
File path: geode-redis/src/main/java/org/apache/geode/redis/internal/executor/key/KeysExecutor.java
##########
@@ -45,7 +47,10 @@ public RedisResponse executeCommand(Command command,
try {
pattern = GlobPattern.compile(glob);
} catch (PatternSyntaxException e) {
- return RedisResponse.error(ERROR_ILLEGAL_GLOB);
+ logger.debug(
Review comment:
Instead of debug, it seems like this should be a warning. Also the log message should mention that it was a pattern given to the KEYS command. Maybe the last sentence could be changed to "KEYS will return an empty list."
Also it seems like you should have some quotes around the curlies for the e.getMessage() and a period after the closing quote.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] sabbeyPivotal commented on a change in pull request #5282: GEODE-8288: Match Redis's glob-style pattern
Posted by GitBox <gi...@apache.org>.
sabbeyPivotal commented on a change in pull request #5282:
URL: https://github.com/apache/geode/pull/5282#discussion_r444925733
##########
File path: geode-redis/src/main/java/org/apache/geode/redis/internal/executor/key/KeysExecutor.java
##########
@@ -45,7 +47,10 @@ public RedisResponse executeCommand(Command command,
try {
pattern = GlobPattern.compile(glob);
} catch (PatternSyntaxException e) {
- return RedisResponse.error(ERROR_ILLEGAL_GLOB);
+ logger.debug(
Review comment:
updated it!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org