You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Kengo Seki (JIRA)" <ji...@apache.org> on 2015/07/10 15:51:04 UTC
[jira] [Updated] (HADOOP-12207) Add support for pylint
[ https://issues.apache.org/jira/browse/HADOOP-12207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kengo Seki updated HADOOP-12207:
--------------------------------
Attachment: HADOOP-12207.HADOOP-12111.00.patch
Attaching a patch. Sample output:
{code}
[sekikn@localhost hadoop]$ cat /tmp/test.patch
diff --git a/dev-support/releasedocmaker.py b/dev-support/releasedocmaker.py
index 2ccc1c0..5aec9e9 100755
--- a/dev-support/releasedocmaker.py
+++ b/dev-support/releasedocmaker.py
@@ -55,7 +55,7 @@ def clean(str):
return tableclean(re.sub(namePattern, "", str))
def formatComponents(str):
- str = re.sub(namePattern, '', str).replace("'", "")
+ str=re.sub(namePattern, '', str).replace("'", "")
if str != "":
ret = str
else:
[sekikn@localhost hadoop]$ dev-support/test-patch.sh --basedir=/home/sekikn/dev/hadoop --project=hadoop --resetrepo /tmp/test.patch
(snip)
| Vote | Subsystem | Runtime | Comment
============================================================================
| +1 | @author | 0m 0s | The patch does not contain any @author
| | | | tags.
| +1 | asflicense | 0m 27s | Patch does not generate ASF License
| | | | warnings.
| -1 | pylint | 0m 1s | Patch generated 1 new pylint issues
| | | | (total was 236, now 237).
| +1 | whitespace | 0m 0s | Patch has no whitespace issues.
| | | 0m 31s |
|| Subsystem || Report/Notes ||
============================================================================
| git revision | trunk / 63d0365 |
| Optional Tests | asflicense pylint |
| uname | Linux localhost.localdomain 2.6.32-504.16.2.el6.x86_64 #1 SMP Wed Apr 22 06:48:29 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/sekikn/hadoop/dev-support/personality/hadoop.sh |
| Default Java | 1.7.0_79 |
| pylint | /tmp/test-patch-hadoop/8215/patch-pylint_global.txt |
{code}
> Add support for pylint
> ----------------------
>
> Key: HADOOP-12207
> URL: https://issues.apache.org/jira/browse/HADOOP-12207
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: yetus
> Reporter: Allen Wittenauer
> Attachments: HADOOP-12207.HADOOP-12111.00.patch
>
>
> In order to make it more obvious why I shouldn't be writing python code, we should add a plugin for pylint similar to what we have for shellcheck.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)