You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/04/27 07:06:44 UTC
[GitHub] [pulsar] lhotari opened a new pull request #10397: [Bookie] Fallback to PULSAR_EXTRA_OPTS if BOOKIE_EXTRA_OPTS isn't defined
lhotari opened a new pull request #10397:
URL: https://github.com/apache/pulsar/pull/10397
### Motivation
- #9469 introduced a breaking change by changing the behavior . This change was part of 2.7.1 release.
### Modifications
- fallback to `PULSAR_EXTRA_OPTS` if `BOOKIE_EXTRA_OPTS` isn't defined
- don't pass `-Dio.netty.*` system properties if `PULSAR_EXTRA_OPTS` or
`BOOKIE_EXTRA_OPTS` is set
- this is to be consistent with `PULSAR_EXTRA_OPTS` behavior and
to prevent duplicate properties
- add `-Dio.netty.leakDetectionLevel=disabled` unless `BOOKIE_EXTRA_OPTS`
is set since `PULSAR_EXTRA_OPTS` doesn't include that setting by default.
(`simple` is the default if the property isn't set)
### Other context
- It is also necessary to cherry-pick #9621 to restore backwards compatibility in 2.7.x branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #10397: [Bookie] Fallback to PULSAR_EXTRA_OPTS if BOOKIE_EXTRA_OPTS isn't defined
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10397:
URL: https://github.com/apache/pulsar/pull/10397#issuecomment-827370310
@eolivelli This and #9621 is needed in 2.7.2 because #9469 in 2.7.1 causes issues for users upgrading to 2.7.x . There's a [slack discussion about it](https://apache-pulsar.slack.com/archives/C5Z4T36F7/p1619465980200600?thread_ts=1619463467.200300&cid=C5Z4T36F7).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #10397: [Bookie] Fallback to PULSAR_EXTRA_OPTS if BOOKIE_EXTRA_OPTS isn't defined
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #10397:
URL: https://github.com/apache/pulsar/pull/10397#issuecomment-828443009
@lhotari
cherry picked to branch-2.7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #10397: [Bookie] Fallback to PULSAR_EXTRA_OPTS if BOOKIE_EXTRA_OPTS isn't defined
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10397:
URL: https://github.com/apache/pulsar/pull/10397#issuecomment-828128485
@codelipenghui @Renkai @eolivelli @murong00 @sijie @addisonj Please review. This is a follow up to #9469 since it breaks backwards compatibility for Pulsar users that are upgrading to Pulsar 2.7.1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #10397: [Bookie] Fallback to PULSAR_EXTRA_OPTS if BOOKIE_EXTRA_OPTS isn't defined
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #10397:
URL: https://github.com/apache/pulsar/pull/10397
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org