You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by sebb <se...@gmail.com> on 2011/05/10 16:13:46 UTC

[VOTE] Release Commons NET 3.0` based on RC1

This is a vote to release Apache Commons NET 3.0 based on RC1.

[ ] +1 release it
[ ] +0 go ahead I don't care
[ ] -1 no, do not release it because...

tag: http://svn.apache.org/repos/asf/commons/proper/net/tags/NET_3_0_RC1/
(r1101459)

site: http://people.apache.org/~sebb/NET_3_0_RC1/

The Javadocs (1.4.1) link does not work, nor does the download link.
These will be fixed once the site is deployed.

Archives (Maven and non-Maven) have been uploaded to:

https://repository.apache.org/content/repositories/orgapachecommons-001/

Vote will remain open for at least 72 hours.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org

Re: [VOTE] Release Commons NET 3.0` based on RC1

Posted by sebb <se...@gmail.com>.
On 11 May 2011 16:15, Gary Gregory <ga...@gmail.com> wrote:
> +1.
>
> If there is another RC, please add a code coverage report.
>
> Shouldn't code coverage be part of the parent POM?

I suggest you file a JIRA so that does not get forgotten.

> Gary
>
> Looks good on:
>
> Apache Maven 3.0.3 (r1075438; 2011-02-28 12:31:09-0500)
> Maven home: C:\Java\apache-maven-3.0.3\bin\..
> Java version: 1.6.0_24, vendor: Sun Microsystems Inc.
> Java home: C:\Program Files\Java\jdk1.6.0_24\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"
>
> On Wed, May 11, 2011 at 5:57 AM, sebb <se...@gmail.com> wrote:
>
>> On 11 May 2011 10:02, Luc Maisonobe <Lu...@free.fr> wrote:
>> > Le 10/05/2011 16:13, sebb a écrit :
>> >>
>> >> This is a vote to release Apache Commons NET 3.0 based on RC1.
>> >>
>> >> [ ] +1 release it
>> >
>> > +1
>> >
>> > I just noticed you didn't put yourself in the developers section of the
>> pom
>> > file. With all the work you have done, you should get some credit.
>>
>> Thanks, but I don't want to add my name to it.
>>
>> SVN history and changes anyway show which code I've updated.
>>
>> > Luc
>> >
>> >> [ ] +0 go ahead I don't care
>> >> [ ] -1 no, do not release it because...
>> >>
>> >> tag:
>> http://svn.apache.org/repos/asf/commons/proper/net/tags/NET_3_0_RC1/
>> >> (r1101459)
>> >>
>> >> site: http://people.apache.org/~sebb/NET_3_0_RC1/
>> >>
>> >> The Javadocs (1.4.1) link does not work, nor does the download link.
>> >> These will be fixed once the site is deployed.
>> >>
>> >> Archives (Maven and non-Maven) have been uploaded to:
>> >>
>> >>
>> https://repository.apache.org/content/repositories/orgapachecommons-001/
>> >>
>> >> Vote will remain open for at least 72 hours.
>> >>
>> >> ---------------------------------------------------------------------
>> >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> >> For additional commands, e-mail: dev-help@commons.apache.org
>> >>
>> >>
>> >
>> >
>> > ---------------------------------------------------------------------
>> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> > For additional commands, e-mail: dev-help@commons.apache.org
>> >
>> >
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
>
>
> --
> Thank you,
> Gary
>
> http://garygregory.wordpress.com/
> http://garygregory.com/
> http://people.apache.org/~ggregory/
> http://twitter.com/GaryGregory
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org

Re: [VOTE] Release Commons NET 3.0` based on RC1

Posted by Gary Gregory <ga...@gmail.com>.
+1.

If there is another RC, please add a code coverage report.

Shouldn't code coverage be part of the parent POM?

Gary

Looks good on:

Apache Maven 3.0.3 (r1075438; 2011-02-28 12:31:09-0500)
Maven home: C:\Java\apache-maven-3.0.3\bin\..
Java version: 1.6.0_24, vendor: Sun Microsystems Inc.
Java home: C:\Program Files\Java\jdk1.6.0_24\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"

On Wed, May 11, 2011 at 5:57 AM, sebb <se...@gmail.com> wrote:

> On 11 May 2011 10:02, Luc Maisonobe <Lu...@free.fr> wrote:
> > Le 10/05/2011 16:13, sebb a écrit :
> >>
> >> This is a vote to release Apache Commons NET 3.0 based on RC1.
> >>
> >> [ ] +1 release it
> >
> > +1
> >
> > I just noticed you didn't put yourself in the developers section of the
> pom
> > file. With all the work you have done, you should get some credit.
>
> Thanks, but I don't want to add my name to it.
>
> SVN history and changes anyway show which code I've updated.
>
> > Luc
> >
> >> [ ] +0 go ahead I don't care
> >> [ ] -1 no, do not release it because...
> >>
> >> tag:
> http://svn.apache.org/repos/asf/commons/proper/net/tags/NET_3_0_RC1/
> >> (r1101459)
> >>
> >> site: http://people.apache.org/~sebb/NET_3_0_RC1/
> >>
> >> The Javadocs (1.4.1) link does not work, nor does the download link.
> >> These will be fixed once the site is deployed.
> >>
> >> Archives (Maven and non-Maven) have been uploaded to:
> >>
> >>
> https://repository.apache.org/content/repositories/orgapachecommons-001/
> >>
> >> Vote will remain open for at least 72 hours.
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> >> For additional commands, e-mail: dev-help@commons.apache.org
> >>
> >>
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>


-- 
Thank you,
Gary

http://garygregory.wordpress.com/
http://garygregory.com/
http://people.apache.org/~ggregory/
http://twitter.com/GaryGregory

Re: [VOTE] Release Commons NET 3.0` based on RC1

Posted by sebb <se...@gmail.com>.
On 11 May 2011 10:02, Luc Maisonobe <Lu...@free.fr> wrote:
> Le 10/05/2011 16:13, sebb a écrit :
>>
>> This is a vote to release Apache Commons NET 3.0 based on RC1.
>>
>> [ ] +1 release it
>
> +1
>
> I just noticed you didn't put yourself in the developers section of the pom
> file. With all the work you have done, you should get some credit.

Thanks, but I don't want to add my name to it.

SVN history and changes anyway show which code I've updated.

> Luc
>
>> [ ] +0 go ahead I don't care
>> [ ] -1 no, do not release it because...
>>
>> tag: http://svn.apache.org/repos/asf/commons/proper/net/tags/NET_3_0_RC1/
>> (r1101459)
>>
>> site: http://people.apache.org/~sebb/NET_3_0_RC1/
>>
>> The Javadocs (1.4.1) link does not work, nor does the download link.
>> These will be fixed once the site is deployed.
>>
>> Archives (Maven and non-Maven) have been uploaded to:
>>
>> https://repository.apache.org/content/repositories/orgapachecommons-001/
>>
>> Vote will remain open for at least 72 hours.
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org

Re: [VOTE] Release Commons NET 3.0` based on RC1

Posted by Luc Maisonobe <Lu...@free.fr>.
Le 10/05/2011 16:13, sebb a écrit :
> This is a vote to release Apache Commons NET 3.0 based on RC1.
>
> [ ] +1 release it

+1

I just noticed you didn't put yourself in the developers section of the 
pom file. With all the work you have done, you should get some credit.

Luc

> [ ] +0 go ahead I don't care
> [ ] -1 no, do not release it because...
>
> tag: http://svn.apache.org/repos/asf/commons/proper/net/tags/NET_3_0_RC1/
> (r1101459)
>
> site: http://people.apache.org/~sebb/NET_3_0_RC1/
>
> The Javadocs (1.4.1) link does not work, nor does the download link.
> These will be fixed once the site is deployed.
>
> Archives (Maven and non-Maven) have been uploaded to:
>
> https://repository.apache.org/content/repositories/orgapachecommons-001/
>
> Vote will remain open for at least 72 hours.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org

Re: [VOTE] Release Commons NET 3.0` based on RC1

Posted by Oliver Heger <ol...@oliver-heger.de>.
Am 11.05.2011 22:26, schrieb sebb:
> On 11 May 2011 21:07, Oliver Heger<ol...@oliver-heger.de>  wrote:
>> Build works fine with Java 1.5 and 1.6 on Windows 7. Artifacts and site look
>> good.
>>
>> Minor nit: When I build the site on my local machine I get 64 findbugs
>> errors. These are not shown on the staged site. According to my local
>> findbugs report 572 classes have been checked while the report on the
>> published site only has 200 classes. I only had a short glance at these
>> errors, but they do not seem to be too problematic.
>
> There are 200 classes in target/classes (this includes examples).
>
> There are 52 classes under target/test-classes - these are not
> included in the Findbugs configuration.
>
> The other 320 classes perhaps come from running Clover?

No idea where they come from. I also have only 202 classes under 
target/classes. However, the findbugs errors are reported in regular 
source classes.

Oliver

>
>> So +1
>>
>> Oliver
>>
>> Am 10.05.2011 16:13, schrieb sebb:
>>>
>>> This is a vote to release Apache Commons NET 3.0 based on RC1.
>>>
>>> [ ] +1 release it
>>> [ ] +0 go ahead I don't care
>>> [ ] -1 no, do not release it because...
>>>
>>> tag: http://svn.apache.org/repos/asf/commons/proper/net/tags/NET_3_0_RC1/
>>> (r1101459)
>>>
>>> site: http://people.apache.org/~sebb/NET_3_0_RC1/
>>>
>>> The Javadocs (1.4.1) link does not work, nor does the download link.
>>> These will be fixed once the site is deployed.
>>>
>>> Archives (Maven and non-Maven) have been uploaded to:
>>>
>>> https://repository.apache.org/content/repositories/orgapachecommons-001/
>>>
>>> Vote will remain open for at least 72 hours.
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org

Re: [VOTE] Release Commons NET 3.0` based on RC1

Posted by sebb <se...@gmail.com>.
On 11 May 2011 21:07, Oliver Heger <ol...@oliver-heger.de> wrote:
> Build works fine with Java 1.5 and 1.6 on Windows 7. Artifacts and site look
> good.
>
> Minor nit: When I build the site on my local machine I get 64 findbugs
> errors. These are not shown on the staged site. According to my local
> findbugs report 572 classes have been checked while the report on the
> published site only has 200 classes. I only had a short glance at these
> errors, but they do not seem to be too problematic.

There are 200 classes in target/classes (this includes examples).

There are 52 classes under target/test-classes - these are not
included in the Findbugs configuration.

The other 320 classes perhaps come from running Clover?

> So +1
>
> Oliver
>
> Am 10.05.2011 16:13, schrieb sebb:
>>
>> This is a vote to release Apache Commons NET 3.0 based on RC1.
>>
>> [ ] +1 release it
>> [ ] +0 go ahead I don't care
>> [ ] -1 no, do not release it because...
>>
>> tag: http://svn.apache.org/repos/asf/commons/proper/net/tags/NET_3_0_RC1/
>> (r1101459)
>>
>> site: http://people.apache.org/~sebb/NET_3_0_RC1/
>>
>> The Javadocs (1.4.1) link does not work, nor does the download link.
>> These will be fixed once the site is deployed.
>>
>> Archives (Maven and non-Maven) have been uploaded to:
>>
>> https://repository.apache.org/content/repositories/orgapachecommons-001/
>>
>> Vote will remain open for at least 72 hours.
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org

Re: [VOTE] Release Commons NET 3.0` based on RC1

Posted by Oliver Heger <ol...@oliver-heger.de>.
Build works fine with Java 1.5 and 1.6 on Windows 7. Artifacts and site 
look good.

Minor nit: When I build the site on my local machine I get 64 findbugs 
errors. These are not shown on the staged site. According to my local 
findbugs report 572 classes have been checked while the report on the 
published site only has 200 classes. I only had a short glance at these 
errors, but they do not seem to be too problematic.

So +1

Oliver

Am 10.05.2011 16:13, schrieb sebb:
> This is a vote to release Apache Commons NET 3.0 based on RC1.
>
> [ ] +1 release it
> [ ] +0 go ahead I don't care
> [ ] -1 no, do not release it because...
>
> tag: http://svn.apache.org/repos/asf/commons/proper/net/tags/NET_3_0_RC1/
> (r1101459)
>
> site: http://people.apache.org/~sebb/NET_3_0_RC1/
>
> The Javadocs (1.4.1) link does not work, nor does the download link.
> These will be fixed once the site is deployed.
>
> Archives (Maven and non-Maven) have been uploaded to:
>
> https://repository.apache.org/content/repositories/orgapachecommons-001/
>
> Vote will remain open for at least 72 hours.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org

Re: [VOTE] Release Commons NET 3.0` based on RC1

Posted by Phil Steitz <ph...@gmail.com>.
On 5/13/11 6:50 AM, Jörg Schaible wrote:
> sebb wrote:
>
>> On 10 May 2011 15:13, sebb <se...@gmail.com> wrote:
>>> This is a vote to release Apache Commons NET 3.0 based on RC1.
>>>
>>> [X] +1 release it
>>> [ ] +0 go ahead I don't care
>>> [ ] -1 no, do not release it because...
>>>
>>> tag: http://svn.apache.org/repos/asf/commons/proper/net/tags/NET_3_0_RC1/
>>> (r1101459)
>>>
>>> site: http://people.apache.org/~sebb/NET_3_0_RC1/
>>>
>>> The Javadocs (1.4.1) link does not work, nor does the download link.
>>> These will be fixed once the site is deployed.
>>>
>>> Archives (Maven and non-Maven) have been uploaded to:
>>>
>>> https://repository.apache.org/content/repositories/orgapachecommons-001/
>>>
>>> Vote will remain open for at least 72 hours.
>> A couple of hours left ...
> Hehehe :)
>
> +1
>
> Builds and runs with my compiler zoo.

OK, I will forgo testing throughout my comparatively limited
endangered compiler shelter and vote
+1

- builds and runs fine on Java(TM) SE Runtime Environment (build
1.6.0_24-b07-334-10M3326)
Java HotSpot(TM) 64-Bit Server VM (build 19.1-b02-334, mixed mode)

- sigs and hashes are good (but no WOT for the sig)

- release contents good

Nice job on the release notes.

Might want to keep the VOTE open a while longer for others to weigh in.

Phil

> - Jörg
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org

Re: [VOTE] Release Commons NET 3.0` based on RC1

Posted by Jörg Schaible <jo...@gmx.de>.
sebb wrote:

> On 10 May 2011 15:13, sebb <se...@gmail.com> wrote:
>> This is a vote to release Apache Commons NET 3.0 based on RC1.
>>
>> [X] +1 release it
>> [ ] +0 go ahead I don't care
>> [ ] -1 no, do not release it because...
>>
>> tag: http://svn.apache.org/repos/asf/commons/proper/net/tags/NET_3_0_RC1/
>> (r1101459)
>>
>> site: http://people.apache.org/~sebb/NET_3_0_RC1/
>>
>> The Javadocs (1.4.1) link does not work, nor does the download link.
>> These will be fixed once the site is deployed.
>>
>> Archives (Maven and non-Maven) have been uploaded to:
>>
>> https://repository.apache.org/content/repositories/orgapachecommons-001/
>>
>> Vote will remain open for at least 72 hours.
> 
> A couple of hours left ...

Hehehe :)

+1

Builds and runs with my compiler zoo.

- Jörg



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org

[VOTE][RESULT] Release Commons NET 3.0` based on RC1

Posted by sebb <se...@gmail.com>.
Thanks very much to all who voted!

The voting was as follows:

Luc Maisonobe +1 (*)
Gary Gregory +1 (*)
Oliver Heger +1 (*)
Sebastian Bazley +1 (*)
Joerg Schaible +1 (*)
Phil Steitz +1 (*)

There were 5 +1 votes (all binding) and no others, so the vote passes.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org

Re: [VOTE] Release Commons NET 3.0` based on RC1

Posted by sebb <se...@gmail.com>.
On 10 May 2011 15:13, sebb <se...@gmail.com> wrote:
> This is a vote to release Apache Commons NET 3.0 based on RC1.
>
> [X] +1 release it
> [ ] +0 go ahead I don't care
> [ ] -1 no, do not release it because...
>
> tag: http://svn.apache.org/repos/asf/commons/proper/net/tags/NET_3_0_RC1/
> (r1101459)
>
> site: http://people.apache.org/~sebb/NET_3_0_RC1/
>
> The Javadocs (1.4.1) link does not work, nor does the download link.
> These will be fixed once the site is deployed.
>
> Archives (Maven and non-Maven) have been uploaded to:
>
> https://repository.apache.org/content/repositories/orgapachecommons-001/
>
> Vote will remain open for at least 72 hours.

A couple of hours left ...

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org