[GitHub] [nifi] NissimShiman commented on a diff in pull request #5878: NIFI-9814: Add Range Sampling strategy to SampleRecord

[GitBox <gi...@apache.org>]

NissimShiman commented on code in PR #5878:
URL: https://github.com/apache/nifi/pull/5878#discussion_r901823349


##########
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/SampleRecord.java:
##########
@@ -114,28 +127,42 @@ public class SampleRecord extends AbstractProcessor {
                     + "used if Sampling Strategy is set to Interval Sampling. A value of zero (0) will cause no records to be included in the"
                     + "outgoing FlowFile, a value of one (1) will cause all records to be included, and a value of two (2) will cause half the "
                     + "records to be included, and so on.")
-            .required(false)
+            .required(true)
             .addValidator(StandardValidators.NON_NEGATIVE_INTEGER_VALIDATOR)
             .expressionLanguageSupported(ExpressionLanguageScope.FLOWFILE_ATTRIBUTES)
+            .dependsOn(SAMPLING_STRATEGY, INTERVAL_SAMPLING)

Review Comment:
   I like the new look of the properties this change brings.  Cleaner look now



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org