You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by jeking3 <gi...@git.apache.org> on 2016/06/22 02:44:59 UTC
[GitHub] thrift pull request #1032: THRIFT-3476: fix missing header
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/1032
THRIFT-3476: fix missing header
stdexcept was missing, but std::runtime_error is used
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeking3/thrift defect/THRIFT-3476
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1032.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1032
----
commit 3201a1d97b7aa09d1d0b5f3f12cd865080f7f97e
Author: Jim King <ji...@simplivity.com>
Date: 2016-06-19T23:46:01Z
THRIFT-3476: fix missing header
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1032: THRIFT-3476: fix missing header
Posted by tpcwang <gi...@git.apache.org>.
Github user tpcwang commented on the issue:
https://github.com/apache/thrift/pull/1032
:+1: makes sense
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1032: THRIFT-3476: fix missing header
Posted by nsuke <gi...@git.apache.org>.
Github user nsuke commented on the issue:
https://github.com/apache/thrift/pull/1032
@jeking3 thanks, merging as failures cannot possibly be related (go and dart).
Filed a [ticket](https://issues.apache.org/jira/browse/THRIFT-3883) for non-cross-test one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1032: THRIFT-3476: fix missing header
Posted by nsuke <gi...@git.apache.org>.
Github user nsuke commented on the issue:
https://github.com/apache/thrift/pull/1032
@jeking3 can you rebase this one too ? It seems quite safe and I could just test it on my travis account but it's always better to have history here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request #1032: THRIFT-3476: fix missing header
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1032
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1032: THRIFT-3476: fix missing header
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1032
Waiting for master to rev so I can rebase and kick this build again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---