You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/29 11:41:03 UTC
[GitHub] [pulsar] nahguam opened a new pull request, #16286: [improve][broker] Optimise msgOutCounter and bytesOutCounter (#16214)
nahguam opened a new pull request, #16286:
URL: https://github.com/apache/pulsar/pull/16286
### Motivation
AbstractTopic#getBytesOutCounter and AbstractTopic#getMsgOutCounter
both generate full stats only to pick the single required counter for
the getters. These can be optimised to perform only the necessary work
to calculate the counters.
### Modification
Provided a scoped implementation of the above methods for the single
counter required for each getter.
<!--
### Contribution Checklist
- PR title format should be *[type][component] summary*. For details, see *[Guideline - Pulsar PR Naming Convention](https://docs.google.com/document/d/1d8Pw6ZbWk-_pCKdOmdvx9rnhPiyuxwq60_TrD68d7BA/edit#heading=h.trs9rsex3xom)*.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
Fixes #16214
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change added tests and can be verified as follows:
```
mvn clean install -Pcore-modules,-main -DskipTests
mvn test -pl pulsar-broker -Dtest="AbstractTopicTest,AbstractSubscriptionTest,ConsumerTest"
```
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (no)
- The public API: (no)
- The schema: (no)
- The default values of configurations: (no)
- The wire protocol: (no)
- The rest endpoints: (no)
- The admin cli options: ( no)
- Anything that affects deployment: (no)
### Documentation
Check the box below or label this PR directly.
Need to update docs?
- [ ] `doc-required`
(Your PR needs to update docs and you will update later)
- [x] `doc-not-needed`
(Please explain why)
Implementation optimisation only
- [ ] `doc`
(Your PR contains doc changes)
- [ ] `doc-complete`
(Docs have been already added)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] RobertIndie merged pull request #16286: [improve][broker] Optimise msgOutCounter and bytesOutCounter (#16214)
Posted by GitBox <gi...@apache.org>.
RobertIndie merged PR #16286:
URL: https://github.com/apache/pulsar/pull/16286
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nahguam commented on pull request #16286: [improve][broker] Optimise msgOutCounter and bytesOutCounter (#16214)
Posted by GitBox <gi...@apache.org>.
nahguam commented on PR #16286:
URL: https://github.com/apache/pulsar/pull/16286#issuecomment-1170928395
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nahguam commented on pull request #16286: [improve][broker] Optimise msgOutCounter and bytesOutCounter (#16214)
Posted by GitBox <gi...@apache.org>.
nahguam commented on PR #16286:
URL: https://github.com/apache/pulsar/pull/16286#issuecomment-1170938125
/pulsarbot run "Unit-BROKER_FLAKY Tests"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao commented on pull request #16286: [improve][broker] Optimise msgOutCounter and bytesOutCounter (#16214)
Posted by GitBox <gi...@apache.org>.
mattisonchao commented on PR #16286:
URL: https://github.com/apache/pulsar/pull/16286#issuecomment-1210630787
#16771 cherry-pick this improvement. So, I remove the release 2.9.4 label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao commented on pull request #16286: [improve][broker] Optimise msgOutCounter and bytesOutCounter (#16214)
Posted by GitBox <gi...@apache.org>.
mattisonchao commented on PR #16286:
URL: https://github.com/apache/pulsar/pull/16286#issuecomment-1172819726
Hi, @nahguam
It looks like this pull request has many conflicts at branch-2.9 could you please help push a new PR to branch 2.9?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org