You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Jonathon Wong (JIRA)" <ji...@apache.org> on 2007/01/15 09:03:27 UTC
[jira] Created: (OFBIZ-627) Creating a purchase order allows
shipping information step to be skipped
Creating a purchase order allows shipping information step to be skipped
------------------------------------------------------------------------
Key: OFBIZ-627
URL: https://issues.apache.org/jira/browse/OFBIZ-627
Project: Apache OFBiz (The Open for Business Project)
Issue Type: Bug
Components: order
Affects Versions: SVN trunk
Reporter: Jonathon Wong
Fix For: SVN trunk
1. Go to ordermgr/control/orderentry
2. Select for Internal Organization a value of "ACCOUNTING" (or some party with
no contact mechanism of type "Postal Address" for shipping purposes).
3. Select a supplier that has something to sell (say DemoSupplier).
4. Add an order item to your PO (say GZ-1000 if using DemoSupplier).
5. Click "Finalize Order". And click through till the "Shipping" tab.
6. You'll see that there are no shipping addresses to choose from. Click
"Continue".
7. You're back to the "Add Order Item" screen. You see error message "Please
enter a shipping address".
8. Click "Finalize Order" again. You've just skipped the "Order" tab (right
after "Shipping" tab) and are now on to "Parties" tab!
9. Select option "I do not wish to add additional parties". Click
"Continue".
10. Back to "Shipping" tab. Again, no shipping addresses to choose from. Click
"Continue".
11. Back to "Add Order Item" screen with same error message as before. Click
"Finalize Order" again.
You're at "Order Confirmation"! There's no shipping information at all for this PO! Go on to create this incomplete PO. You'll see a whole host of problems associated with this PO, including the inability to include shipping information or to correct it otherwise.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-627) Creating a purchase order allows
shipping information step to be skipped
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12466239 ]
Jacques Le Roux commented on OFBIZ-627:
---------------------------------------
Or you may prefer this one : https://issues.apache.org/jira/browse/OFBIZ-552 ?
> Creating a purchase order allows shipping information step to be skipped
> ------------------------------------------------------------------------
>
> Key: OFBIZ-627
> URL: https://issues.apache.org/jira/browse/OFBIZ-627
> Project: Apache OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Reporter: Jonathon Wong
> Assigned To: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: CheckOutEvents.java.patch
>
>
> 1. Go to ordermgr/control/orderentry
> 2. Select for Internal Organization a value of "ACCOUNTING" (or some party with
> no contact mechanism of type "Postal Address" for shipping purposes).
> 3. Select a supplier that has something to sell (say DemoSupplier).
> 4. Add an order item to your PO (say GZ-1000 if using DemoSupplier).
> 5. Click "Finalize Order". And click through till the "Shipping" tab.
> 6. You'll see that there are no shipping addresses to choose from. Click
> "Continue".
> 7. You're back to the "Add Order Item" screen. You see error message "Please
> enter a shipping address".
> 8. Click "Finalize Order" again. You've just skipped the "Order" tab (right
> after "Shipping" tab) and are now on to "Parties" tab!
> 9. Select option "I do not wish to add additional parties". Click
> "Continue".
> 10. Back to "Shipping" tab. Again, no shipping addresses to choose from. Click
> "Continue".
> 11. Back to "Add Order Item" screen with same error message as before. Click
> "Finalize Order" again.
> You're at "Order Confirmation"! There's no shipping information at all for this PO! Go on to create this incomplete PO. You'll see a whole host of problems associated with this PO, including the inability to include shipping information or to correct it otherwise.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-627) Creating a purchase order allows
shipping information step to be skipped
Posted by "Jonathon Wong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12466225 ]
Jonathon Wong commented on OFBIZ-627:
-------------------------------------
Jacques, I was wondering whether it'd be wrong for you to complain about our patches, like "it's not good enough yet". Then there'll be less unstable commits.
> Creating a purchase order allows shipping information step to be skipped
> ------------------------------------------------------------------------
>
> Key: OFBIZ-627
> URL: https://issues.apache.org/jira/browse/OFBIZ-627
> Project: Apache OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Reporter: Jonathon Wong
> Assigned To: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: CheckOutEvents.java.patch
>
>
> 1. Go to ordermgr/control/orderentry
> 2. Select for Internal Organization a value of "ACCOUNTING" (or some party with
> no contact mechanism of type "Postal Address" for shipping purposes).
> 3. Select a supplier that has something to sell (say DemoSupplier).
> 4. Add an order item to your PO (say GZ-1000 if using DemoSupplier).
> 5. Click "Finalize Order". And click through till the "Shipping" tab.
> 6. You'll see that there are no shipping addresses to choose from. Click
> "Continue".
> 7. You're back to the "Add Order Item" screen. You see error message "Please
> enter a shipping address".
> 8. Click "Finalize Order" again. You've just skipped the "Order" tab (right
> after "Shipping" tab) and are now on to "Parties" tab!
> 9. Select option "I do not wish to add additional parties". Click
> "Continue".
> 10. Back to "Shipping" tab. Again, no shipping addresses to choose from. Click
> "Continue".
> 11. Back to "Add Order Item" screen with same error message as before. Click
> "Finalize Order" again.
> You're at "Order Confirmation"! There's no shipping information at all for this PO! Go on to create this incomplete PO. You'll see a whole host of problems associated with this PO, including the inability to include shipping information or to correct it otherwise.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-627) Creating a purchase order allows
shipping information step to be skipped
Posted by "Jonathon Wong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12464686 ]
Jonathon Wong commented on OFBIZ-627:
-------------------------------------
Chris,
You're absolutely right. I say we fix the 1st issue (I created this issue with type "Bug"). Without the 1st issue (bug), we'd never have to address the 2nd issue (improvement).
Can you help fix this in minutes? Probably takes me days. : ) TIA!
> Creating a purchase order allows shipping information step to be skipped
> ------------------------------------------------------------------------
>
> Key: OFBIZ-627
> URL: https://issues.apache.org/jira/browse/OFBIZ-627
> Project: Apache OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Reporter: Jonathon Wong
> Fix For: SVN trunk
>
>
> 1. Go to ordermgr/control/orderentry
> 2. Select for Internal Organization a value of "ACCOUNTING" (or some party with
> no contact mechanism of type "Postal Address" for shipping purposes).
> 3. Select a supplier that has something to sell (say DemoSupplier).
> 4. Add an order item to your PO (say GZ-1000 if using DemoSupplier).
> 5. Click "Finalize Order". And click through till the "Shipping" tab.
> 6. You'll see that there are no shipping addresses to choose from. Click
> "Continue".
> 7. You're back to the "Add Order Item" screen. You see error message "Please
> enter a shipping address".
> 8. Click "Finalize Order" again. You've just skipped the "Order" tab (right
> after "Shipping" tab) and are now on to "Parties" tab!
> 9. Select option "I do not wish to add additional parties". Click
> "Continue".
> 10. Back to "Shipping" tab. Again, no shipping addresses to choose from. Click
> "Continue".
> 11. Back to "Add Order Item" screen with same error message as before. Click
> "Finalize Order" again.
> You're at "Order Confirmation"! There's no shipping information at all for this PO! Go on to create this incomplete PO. You'll see a whole host of problems associated with this PO, including the inability to include shipping information or to correct it otherwise.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (OFBIZ-627) Creating a purchase order allows
shipping information step to be skipped
Posted by "Jonathon Wong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathon Wong updated OFBIZ-627:
--------------------------------
Attachment: CheckOutEvents.java.patch
> Creating a purchase order allows shipping information step to be skipped
> ------------------------------------------------------------------------
>
> Key: OFBIZ-627
> URL: https://issues.apache.org/jira/browse/OFBIZ-627
> Project: Apache OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Reporter: Jonathon Wong
> Fix For: SVN trunk
>
> Attachments: CheckOutEvents.java.patch
>
>
> 1. Go to ordermgr/control/orderentry
> 2. Select for Internal Organization a value of "ACCOUNTING" (or some party with
> no contact mechanism of type "Postal Address" for shipping purposes).
> 3. Select a supplier that has something to sell (say DemoSupplier).
> 4. Add an order item to your PO (say GZ-1000 if using DemoSupplier).
> 5. Click "Finalize Order". And click through till the "Shipping" tab.
> 6. You'll see that there are no shipping addresses to choose from. Click
> "Continue".
> 7. You're back to the "Add Order Item" screen. You see error message "Please
> enter a shipping address".
> 8. Click "Finalize Order" again. You've just skipped the "Order" tab (right
> after "Shipping" tab) and are now on to "Parties" tab!
> 9. Select option "I do not wish to add additional parties". Click
> "Continue".
> 10. Back to "Shipping" tab. Again, no shipping addresses to choose from. Click
> "Continue".
> 11. Back to "Add Order Item" screen with same error message as before. Click
> "Finalize Order" again.
> You're at "Order Confirmation"! There's no shipping information at all for this PO! Go on to create this incomplete PO. You'll see a whole host of problems associated with this PO, including the inability to include shipping information or to correct it otherwise.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-627) Creating a purchase order allows
shipping information step to be skipped
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12466253 ]
Jacques Le Roux commented on OFBIZ-627:
---------------------------------------
Hé, Jonathon,
I was joking, perhaps I'm a little too much sensitive. I replied to your 2 points in another msg in the dev ML. Thanks to care :o)
Your patch was good. Actually for this "bug" the best should be to create another issue. I asked before because I'm not sure of the "non functionnality" (not sure how it should or should not work). Feel free to create an issue if you think we should but once more I did not intend this remark to you. If you have other prirorities this can wait. A new issue should be sufficient.
> Creating a purchase order allows shipping information step to be skipped
> ------------------------------------------------------------------------
>
> Key: OFBIZ-627
> URL: https://issues.apache.org/jira/browse/OFBIZ-627
> Project: Apache OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Reporter: Jonathon Wong
> Assigned To: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: CheckOutEvents.java.patch
>
>
> 1. Go to ordermgr/control/orderentry
> 2. Select for Internal Organization a value of "ACCOUNTING" (or some party with
> no contact mechanism of type "Postal Address" for shipping purposes).
> 3. Select a supplier that has something to sell (say DemoSupplier).
> 4. Add an order item to your PO (say GZ-1000 if using DemoSupplier).
> 5. Click "Finalize Order". And click through till the "Shipping" tab.
> 6. You'll see that there are no shipping addresses to choose from. Click
> "Continue".
> 7. You're back to the "Add Order Item" screen. You see error message "Please
> enter a shipping address".
> 8. Click "Finalize Order" again. You've just skipped the "Order" tab (right
> after "Shipping" tab) and are now on to "Parties" tab!
> 9. Select option "I do not wish to add additional parties". Click
> "Continue".
> 10. Back to "Shipping" tab. Again, no shipping addresses to choose from. Click
> "Continue".
> 11. Back to "Add Order Item" screen with same error message as before. Click
> "Finalize Order" again.
> You're at "Order Confirmation"! There's no shipping information at all for this PO! Go on to create this incomplete PO. You'll see a whole host of problems associated with this PO, including the inability to include shipping information or to correct it otherwise.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-627) Creating a purchase order allows
shipping information step to be skipped
Posted by "Chris Howe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12464710 ]
Chris Howe commented on OFBIZ-627:
----------------------------------
That should pop every error that occured when the finalizeMode = "ship". I'm pretty sure that the "ship" finalizeMode is only set from that shipping page.. I could be wrong. Feel free to look into it. It's well past bedtime here :)
> Creating a purchase order allows shipping information step to be skipped
> ------------------------------------------------------------------------
>
> Key: OFBIZ-627
> URL: https://issues.apache.org/jira/browse/OFBIZ-627
> Project: Apache OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Reporter: Jonathon Wong
> Fix For: SVN trunk
>
>
> 1. Go to ordermgr/control/orderentry
> 2. Select for Internal Organization a value of "ACCOUNTING" (or some party with
> no contact mechanism of type "Postal Address" for shipping purposes).
> 3. Select a supplier that has something to sell (say DemoSupplier).
> 4. Add an order item to your PO (say GZ-1000 if using DemoSupplier).
> 5. Click "Finalize Order". And click through till the "Shipping" tab.
> 6. You'll see that there are no shipping addresses to choose from. Click
> "Continue".
> 7. You're back to the "Add Order Item" screen. You see error message "Please
> enter a shipping address".
> 8. Click "Finalize Order" again. You've just skipped the "Order" tab (right
> after "Shipping" tab) and are now on to "Parties" tab!
> 9. Select option "I do not wish to add additional parties". Click
> "Continue".
> 10. Back to "Shipping" tab. Again, no shipping addresses to choose from. Click
> "Continue".
> 11. Back to "Add Order Item" screen with same error message as before. Click
> "Finalize Order" again.
> You're at "Order Confirmation"! There's no shipping information at all for this PO! Go on to create this incomplete PO. You'll see a whole host of problems associated with this PO, including the inability to include shipping information or to correct it otherwise.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-627) Creating a purchase order allows
shipping information step to be skipped
Posted by "Chris Howe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12464677 ]
Chris Howe commented on OFBIZ-627:
----------------------------------
There are two issues here
1. A bug - curPage (variable name from my memory) is advancing when there is an error
2. improvement - Shipping options page should give you the option of adding a shipping address for this partyId
> Creating a purchase order allows shipping information step to be skipped
> ------------------------------------------------------------------------
>
> Key: OFBIZ-627
> URL: https://issues.apache.org/jira/browse/OFBIZ-627
> Project: Apache OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Reporter: Jonathon Wong
> Fix For: SVN trunk
>
>
> 1. Go to ordermgr/control/orderentry
> 2. Select for Internal Organization a value of "ACCOUNTING" (or some party with
> no contact mechanism of type "Postal Address" for shipping purposes).
> 3. Select a supplier that has something to sell (say DemoSupplier).
> 4. Add an order item to your PO (say GZ-1000 if using DemoSupplier).
> 5. Click "Finalize Order". And click through till the "Shipping" tab.
> 6. You'll see that there are no shipping addresses to choose from. Click
> "Continue".
> 7. You're back to the "Add Order Item" screen. You see error message "Please
> enter a shipping address".
> 8. Click "Finalize Order" again. You've just skipped the "Order" tab (right
> after "Shipping" tab) and are now on to "Parties" tab!
> 9. Select option "I do not wish to add additional parties". Click
> "Continue".
> 10. Back to "Shipping" tab. Again, no shipping addresses to choose from. Click
> "Continue".
> 11. Back to "Add Order Item" screen with same error message as before. Click
> "Finalize Order" again.
> You're at "Order Confirmation"! There's no shipping information at all for this PO! Go on to create this incomplete PO. You'll see a whole host of problems associated with this PO, including the inability to include shipping information or to correct it otherwise.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-627) Creating a purchase order allows
shipping information step to be skipped
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12466238 ]
Jacques Le Roux commented on OFBIZ-627:
---------------------------------------
Jonathon,
Want to help ? Take a look at this one https://issues.apache.org/jira/browse/OFBIZ-326 :o)
> Creating a purchase order allows shipping information step to be skipped
> ------------------------------------------------------------------------
>
> Key: OFBIZ-627
> URL: https://issues.apache.org/jira/browse/OFBIZ-627
> Project: Apache OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Reporter: Jonathon Wong
> Assigned To: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: CheckOutEvents.java.patch
>
>
> 1. Go to ordermgr/control/orderentry
> 2. Select for Internal Organization a value of "ACCOUNTING" (or some party with
> no contact mechanism of type "Postal Address" for shipping purposes).
> 3. Select a supplier that has something to sell (say DemoSupplier).
> 4. Add an order item to your PO (say GZ-1000 if using DemoSupplier).
> 5. Click "Finalize Order". And click through till the "Shipping" tab.
> 6. You'll see that there are no shipping addresses to choose from. Click
> "Continue".
> 7. You're back to the "Add Order Item" screen. You see error message "Please
> enter a shipping address".
> 8. Click "Finalize Order" again. You've just skipped the "Order" tab (right
> after "Shipping" tab) and are now on to "Parties" tab!
> 9. Select option "I do not wish to add additional parties". Click
> "Continue".
> 10. Back to "Shipping" tab. Again, no shipping addresses to choose from. Click
> "Continue".
> 11. Back to "Add Order Item" screen with same error message as before. Click
> "Finalize Order" again.
> You're at "Order Confirmation"! There's no shipping information at all for this PO! Go on to create this incomplete PO. You'll see a whole host of problems associated with this PO, including the inability to include shipping information or to correct it otherwise.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-627) Creating a purchase order allows
shipping information step to be skipped
Posted by "Jonathon Wong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12464706 ]
Jonathon Wong commented on OFBIZ-627:
-------------------------------------
Chris,
But wouldn't that pop every error case back to the Shipping step? Yeah, I don't think the community will want this. We never know what new and non-shipping related errors could arise from the "Create a PO" process.
> Creating a purchase order allows shipping information step to be skipped
> ------------------------------------------------------------------------
>
> Key: OFBIZ-627
> URL: https://issues.apache.org/jira/browse/OFBIZ-627
> Project: Apache OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Reporter: Jonathon Wong
> Fix For: SVN trunk
>
>
> 1. Go to ordermgr/control/orderentry
> 2. Select for Internal Organization a value of "ACCOUNTING" (or some party with
> no contact mechanism of type "Postal Address" for shipping purposes).
> 3. Select a supplier that has something to sell (say DemoSupplier).
> 4. Add an order item to your PO (say GZ-1000 if using DemoSupplier).
> 5. Click "Finalize Order". And click through till the "Shipping" tab.
> 6. You'll see that there are no shipping addresses to choose from. Click
> "Continue".
> 7. You're back to the "Add Order Item" screen. You see error message "Please
> enter a shipping address".
> 8. Click "Finalize Order" again. You've just skipped the "Order" tab (right
> after "Shipping" tab) and are now on to "Parties" tab!
> 9. Select option "I do not wish to add additional parties". Click
> "Continue".
> 10. Back to "Shipping" tab. Again, no shipping addresses to choose from. Click
> "Continue".
> 11. Back to "Add Order Item" screen with same error message as before. Click
> "Finalize Order" again.
> You're at "Order Confirmation"! There's no shipping information at all for this PO! Go on to create this incomplete PO. You'll see a whole host of problems associated with this PO, including the inability to include shipping information or to correct it otherwise.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-627) Creating a purchase order allows
shipping information step to be skipped
Posted by "Chris Howe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12464700 ]
Chris Howe commented on OFBIZ-627:
----------------------------------
I'm afraid I don't have a clean environment to test this solution (or create a patch from) and it may not be desirable from the community POV, but this is what I would do:
org.ofbiz.order.shoppingCart.CheckOutEventes.java
line 701
change
return "error";
to
return "shipping"
this will simply change the flow from going back to the beginning to going back to the screen where you set the shipping. I believe it will still print the error message, which is a good thing.
> Creating a purchase order allows shipping information step to be skipped
> ------------------------------------------------------------------------
>
> Key: OFBIZ-627
> URL: https://issues.apache.org/jira/browse/OFBIZ-627
> Project: Apache OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Reporter: Jonathon Wong
> Fix For: SVN trunk
>
>
> 1. Go to ordermgr/control/orderentry
> 2. Select for Internal Organization a value of "ACCOUNTING" (or some party with
> no contact mechanism of type "Postal Address" for shipping purposes).
> 3. Select a supplier that has something to sell (say DemoSupplier).
> 4. Add an order item to your PO (say GZ-1000 if using DemoSupplier).
> 5. Click "Finalize Order". And click through till the "Shipping" tab.
> 6. You'll see that there are no shipping addresses to choose from. Click
> "Continue".
> 7. You're back to the "Add Order Item" screen. You see error message "Please
> enter a shipping address".
> 8. Click "Finalize Order" again. You've just skipped the "Order" tab (right
> after "Shipping" tab) and are now on to "Parties" tab!
> 9. Select option "I do not wish to add additional parties". Click
> "Continue".
> 10. Back to "Shipping" tab. Again, no shipping addresses to choose from. Click
> "Continue".
> 11. Back to "Add Order Item" screen with same error message as before. Click
> "Finalize Order" again.
> You're at "Order Confirmation"! There's no shipping information at all for this PO! Go on to create this incomplete PO. You'll see a whole host of problems associated with this PO, including the inability to include shipping information or to correct it otherwise.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-627) Creating a purchase order allows
shipping information step to be skipped
Posted by "Anil K Patel (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12464675 ]
Anil K Patel commented on OFBIZ-627:
------------------------------------
Did you try adding Shipping Address of the Buying Party, In this case may be "Company" . Now if you try doing process you listed above, you should get success.
> Creating a purchase order allows shipping information step to be skipped
> ------------------------------------------------------------------------
>
> Key: OFBIZ-627
> URL: https://issues.apache.org/jira/browse/OFBIZ-627
> Project: Apache OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Reporter: Jonathon Wong
> Fix For: SVN trunk
>
>
> 1. Go to ordermgr/control/orderentry
> 2. Select for Internal Organization a value of "ACCOUNTING" (or some party with
> no contact mechanism of type "Postal Address" for shipping purposes).
> 3. Select a supplier that has something to sell (say DemoSupplier).
> 4. Add an order item to your PO (say GZ-1000 if using DemoSupplier).
> 5. Click "Finalize Order". And click through till the "Shipping" tab.
> 6. You'll see that there are no shipping addresses to choose from. Click
> "Continue".
> 7. You're back to the "Add Order Item" screen. You see error message "Please
> enter a shipping address".
> 8. Click "Finalize Order" again. You've just skipped the "Order" tab (right
> after "Shipping" tab) and are now on to "Parties" tab!
> 9. Select option "I do not wish to add additional parties". Click
> "Continue".
> 10. Back to "Shipping" tab. Again, no shipping addresses to choose from. Click
> "Continue".
> 11. Back to "Add Order Item" screen with same error message as before. Click
> "Finalize Order" again.
> You're at "Order Confirmation"! There's no shipping information at all for this PO! Go on to create this incomplete PO. You'll see a whole host of problems associated with this PO, including the inability to include shipping information or to correct it otherwise.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-627) Creating a purchase order allows
shipping information step to be skipped
Posted by "Jonathon Wong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12464767 ]
Jonathon Wong commented on OFBIZ-627:
-------------------------------------
I've included the patch. I can't begin to mention how the problems are fixed, because the error scenarios are a little convoluted. Easier to say what I did.
At line 701, I added a check to determine the current "mode" of operation (hidden variable "finalizeMode" on html). Based on the current "mode", I called for the appropriate response. Eg, if user was doing shipping when error occurred, go back to shipping screen. Used to go back to "Add Order Item" screen.
In function determineNextFinalizeStep(), I had to force checks on customer (web variable "finalizeReqCustInfo"), shipping ("finalizeReqShipInfo"), shipping options ("finalizeReqOptions"), and additional party ("finalizeReqAdditionalParty"). For some reason I don't really care to check for now, webapp/ordermgr/entry/OrderEntryTabBar.ftl sets checks to false for customer, shipping (the cause of my problems initially!), shipping options, and payment.
I refactored the checks ("if" clauses) into a more flexible for-loop, so that the order of checks can depend on a String array "processOrder". I had to change the order of check for terms to 2nd place (was put after shipping options), but only when dealing with POs. I left the order of checks untouched when not dealing POs, so this bugfix should have minimal footprint and not stomp other functions or scenarios.
All in all, the PO screens and process flow should be fixed once and for all by this patch. Users can now go back and forth in the process flow without errors.
> Creating a purchase order allows shipping information step to be skipped
> ------------------------------------------------------------------------
>
> Key: OFBIZ-627
> URL: https://issues.apache.org/jira/browse/OFBIZ-627
> Project: Apache OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Reporter: Jonathon Wong
> Fix For: SVN trunk
>
> Attachments: CheckOutEvents.java.patch
>
>
> 1. Go to ordermgr/control/orderentry
> 2. Select for Internal Organization a value of "ACCOUNTING" (or some party with
> no contact mechanism of type "Postal Address" for shipping purposes).
> 3. Select a supplier that has something to sell (say DemoSupplier).
> 4. Add an order item to your PO (say GZ-1000 if using DemoSupplier).
> 5. Click "Finalize Order". And click through till the "Shipping" tab.
> 6. You'll see that there are no shipping addresses to choose from. Click
> "Continue".
> 7. You're back to the "Add Order Item" screen. You see error message "Please
> enter a shipping address".
> 8. Click "Finalize Order" again. You've just skipped the "Order" tab (right
> after "Shipping" tab) and are now on to "Parties" tab!
> 9. Select option "I do not wish to add additional parties". Click
> "Continue".
> 10. Back to "Shipping" tab. Again, no shipping addresses to choose from. Click
> "Continue".
> 11. Back to "Add Order Item" screen with same error message as before. Click
> "Finalize Order" again.
> You're at "Order Confirmation"! There's no shipping information at all for this PO! Go on to create this incomplete PO. You'll see a whole host of problems associated with this PO, including the inability to include shipping information or to correct it otherwise.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (OFBIZ-627) Creating a purchase order allows
shipping information step to be skipped
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux closed OFBIZ-627.
---------------------------------
Resolution: Fixed
Jonathon,
I reviewed and tested your patch without problem, it is in OFBiz rev. 498094. I had alrady seen this problem and yes your patch fix it.
However I wonder (this is out of subject) why when you choose to ship to another party having an adress it still fails. Is that normal, anybody an idea, explanation ?
Thanks
> Creating a purchase order allows shipping information step to be skipped
> ------------------------------------------------------------------------
>
> Key: OFBIZ-627
> URL: https://issues.apache.org/jira/browse/OFBIZ-627
> Project: Apache OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Reporter: Jonathon Wong
> Assigned To: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: CheckOutEvents.java.patch
>
>
> 1. Go to ordermgr/control/orderentry
> 2. Select for Internal Organization a value of "ACCOUNTING" (or some party with
> no contact mechanism of type "Postal Address" for shipping purposes).
> 3. Select a supplier that has something to sell (say DemoSupplier).
> 4. Add an order item to your PO (say GZ-1000 if using DemoSupplier).
> 5. Click "Finalize Order". And click through till the "Shipping" tab.
> 6. You'll see that there are no shipping addresses to choose from. Click
> "Continue".
> 7. You're back to the "Add Order Item" screen. You see error message "Please
> enter a shipping address".
> 8. Click "Finalize Order" again. You've just skipped the "Order" tab (right
> after "Shipping" tab) and are now on to "Parties" tab!
> 9. Select option "I do not wish to add additional parties". Click
> "Continue".
> 10. Back to "Shipping" tab. Again, no shipping addresses to choose from. Click
> "Continue".
> 11. Back to "Add Order Item" screen with same error message as before. Click
> "Finalize Order" again.
> You're at "Order Confirmation"! There's no shipping information at all for this PO! Go on to create this incomplete PO. You'll see a whole host of problems associated with this PO, including the inability to include shipping information or to correct it otherwise.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-627) Creating a purchase order allows
shipping information step to be skipped
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12466237 ]
Jacques Le Roux commented on OFBIZ-627:
---------------------------------------
Jonathon,
You know what ? I'm a weak person ;o)
Seriously, this patch was sound, solved the problem we got, what else wanted ?
It was a question at large, not directed to you. Anyway if someone know about that point...
> Creating a purchase order allows shipping information step to be skipped
> ------------------------------------------------------------------------
>
> Key: OFBIZ-627
> URL: https://issues.apache.org/jira/browse/OFBIZ-627
> Project: Apache OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Reporter: Jonathon Wong
> Assigned To: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: CheckOutEvents.java.patch
>
>
> 1. Go to ordermgr/control/orderentry
> 2. Select for Internal Organization a value of "ACCOUNTING" (or some party with
> no contact mechanism of type "Postal Address" for shipping purposes).
> 3. Select a supplier that has something to sell (say DemoSupplier).
> 4. Add an order item to your PO (say GZ-1000 if using DemoSupplier).
> 5. Click "Finalize Order". And click through till the "Shipping" tab.
> 6. You'll see that there are no shipping addresses to choose from. Click
> "Continue".
> 7. You're back to the "Add Order Item" screen. You see error message "Please
> enter a shipping address".
> 8. Click "Finalize Order" again. You've just skipped the "Order" tab (right
> after "Shipping" tab) and are now on to "Parties" tab!
> 9. Select option "I do not wish to add additional parties". Click
> "Continue".
> 10. Back to "Shipping" tab. Again, no shipping addresses to choose from. Click
> "Continue".
> 11. Back to "Add Order Item" screen with same error message as before. Click
> "Finalize Order" again.
> You're at "Order Confirmation"! There's no shipping information at all for this PO! Go on to create this incomplete PO. You'll see a whole host of problems associated with this PO, including the inability to include shipping information or to correct it otherwise.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-627) Creating a purchase order allows
shipping information step to be skipped
Posted by "Jonathon Wong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12466246 ]
Jonathon Wong commented on OFBIZ-627:
-------------------------------------
Jacques,
What do you mean by "weak person"?
I still wish there was something that could:
1. Make life easier for committers
2. Free committers up to really review our patches (just so there won't be unstable/wrong commits.)
I'll look at my patch here again for the bug you mentioned.
> Creating a purchase order allows shipping information step to be skipped
> ------------------------------------------------------------------------
>
> Key: OFBIZ-627
> URL: https://issues.apache.org/jira/browse/OFBIZ-627
> Project: Apache OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Reporter: Jonathon Wong
> Assigned To: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: CheckOutEvents.java.patch
>
>
> 1. Go to ordermgr/control/orderentry
> 2. Select for Internal Organization a value of "ACCOUNTING" (or some party with
> no contact mechanism of type "Postal Address" for shipping purposes).
> 3. Select a supplier that has something to sell (say DemoSupplier).
> 4. Add an order item to your PO (say GZ-1000 if using DemoSupplier).
> 5. Click "Finalize Order". And click through till the "Shipping" tab.
> 6. You'll see that there are no shipping addresses to choose from. Click
> "Continue".
> 7. You're back to the "Add Order Item" screen. You see error message "Please
> enter a shipping address".
> 8. Click "Finalize Order" again. You've just skipped the "Order" tab (right
> after "Shipping" tab) and are now on to "Parties" tab!
> 9. Select option "I do not wish to add additional parties". Click
> "Continue".
> 10. Back to "Shipping" tab. Again, no shipping addresses to choose from. Click
> "Continue".
> 11. Back to "Add Order Item" screen with same error message as before. Click
> "Finalize Order" again.
> You're at "Order Confirmation"! There's no shipping information at all for this PO! Go on to create this incomplete PO. You'll see a whole host of problems associated with this PO, including the inability to include shipping information or to correct it otherwise.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (OFBIZ-627) Creating a purchase order allows
shipping information step to be skipped
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux reassigned OFBIZ-627:
-------------------------------------
Assignee: Jacques Le Roux
> Creating a purchase order allows shipping information step to be skipped
> ------------------------------------------------------------------------
>
> Key: OFBIZ-627
> URL: https://issues.apache.org/jira/browse/OFBIZ-627
> Project: Apache OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Reporter: Jonathon Wong
> Assigned To: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: CheckOutEvents.java.patch
>
>
> 1. Go to ordermgr/control/orderentry
> 2. Select for Internal Organization a value of "ACCOUNTING" (or some party with
> no contact mechanism of type "Postal Address" for shipping purposes).
> 3. Select a supplier that has something to sell (say DemoSupplier).
> 4. Add an order item to your PO (say GZ-1000 if using DemoSupplier).
> 5. Click "Finalize Order". And click through till the "Shipping" tab.
> 6. You'll see that there are no shipping addresses to choose from. Click
> "Continue".
> 7. You're back to the "Add Order Item" screen. You see error message "Please
> enter a shipping address".
> 8. Click "Finalize Order" again. You've just skipped the "Order" tab (right
> after "Shipping" tab) and are now on to "Parties" tab!
> 9. Select option "I do not wish to add additional parties". Click
> "Continue".
> 10. Back to "Shipping" tab. Again, no shipping addresses to choose from. Click
> "Continue".
> 11. Back to "Add Order Item" screen with same error message as before. Click
> "Finalize Order" again.
> You're at "Order Confirmation"! There's no shipping information at all for this PO! Go on to create this incomplete PO. You'll see a whole host of problems associated with this PO, including the inability to include shipping information or to correct it otherwise.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-627) Creating a purchase order allows
shipping information step to be skipped
Posted by "Jonathon Wong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12466224 ]
Jonathon Wong commented on OFBIZ-627:
-------------------------------------
Jacques,
Oh, er... I only tested it to work with "ship to myself", not to another party. Want me to look into this? Or you can help me (TIA)?
My fix is done with the smallest footprint possible, so it won't break existing functionalities nor solve existing problems. It just solves the problem I spotted. :P
> Creating a purchase order allows shipping information step to be skipped
> ------------------------------------------------------------------------
>
> Key: OFBIZ-627
> URL: https://issues.apache.org/jira/browse/OFBIZ-627
> Project: Apache OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Reporter: Jonathon Wong
> Assigned To: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: CheckOutEvents.java.patch
>
>
> 1. Go to ordermgr/control/orderentry
> 2. Select for Internal Organization a value of "ACCOUNTING" (or some party with
> no contact mechanism of type "Postal Address" for shipping purposes).
> 3. Select a supplier that has something to sell (say DemoSupplier).
> 4. Add an order item to your PO (say GZ-1000 if using DemoSupplier).
> 5. Click "Finalize Order". And click through till the "Shipping" tab.
> 6. You'll see that there are no shipping addresses to choose from. Click
> "Continue".
> 7. You're back to the "Add Order Item" screen. You see error message "Please
> enter a shipping address".
> 8. Click "Finalize Order" again. You've just skipped the "Order" tab (right
> after "Shipping" tab) and are now on to "Parties" tab!
> 9. Select option "I do not wish to add additional parties". Click
> "Continue".
> 10. Back to "Shipping" tab. Again, no shipping addresses to choose from. Click
> "Continue".
> 11. Back to "Add Order Item" screen with same error message as before. Click
> "Finalize Order" again.
> You're at "Order Confirmation"! There's no shipping information at all for this PO! Go on to create this incomplete PO. You'll see a whole host of problems associated with this PO, including the inability to include shipping information or to correct it otherwise.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira