[GitHub] [kylin] nichunen commented on a change in pull request #1024: KYLIN-4315 use metadata numRows in beeline client for quick row counting

[GitBox <gi...@apache.org>]

nichunen commented on a change in pull request #1024: KYLIN-4315 use metadata numRows in beeline client for quick row counting
URL: https://github.com/apache/kylin/pull/1024#discussion_r368987064
 
 

 ##########
 File path: source-hive/src/main/java/org/apache/kylin/source/hive/BeelineHiveClient.java
 ##########
 @@ -272,6 +261,9 @@ private void extractTableParam(ResultSet resultSet, HiveTableMetaBuilder builder
             if ("numFiles".equals(resultSet.getString(2).trim())) {
                 builder.setFileNum(Long.parseLong(resultSet.getString(3).trim()));
             }
+            if ("numRows".equals(resultSet.getString(2).trim())) {
+                builder.setRowNum(Long.parseLong(resultSet.getString(3).trim()));
 
 Review comment:
   Is it certain that "numRows" will always be gotten in hive table's meta? As I know, there is possibility that it be -1

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services