You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/02/07 18:08:00 UTC
[GitHub] [arrow] dragosmg opened a new pull request #12360: [R] R package URL updates
dragosmg opened a new pull request #12360:
URL: https://github.com/apache/arrow/pull/12360
This PR aims to solve some of the `urlchecker::url_check()` findings.
3 complaints from the `urlchecker` are left:
* Conda forge badge, for which the URL is correct:
```
Error: README.md:5:75 400: Bad Request
[](https://anaconda.org/conda-forge/r-arrow)
```
* 2 for articles which have not yet been published:
```
x Error: vignettes/developing.Rmd:16:46 404: Not Found
* [running R with the C++ debugger attached](https://arrow.apache.org/docs/r/articles/developers/debugging.html)```
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
x Error: vignettes/install.Rmd:18:33 404: Not Found
[developers' installation docs](https://arrow.apache.org/docs/r/articles/developers/install_details.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12360: MINOR: [R] Update a URL to https
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12360:
URL: https://github.com/apache/arrow/pull/12360#issuecomment-1032897640
Benchmark runs are scheduled for baseline = 11e9f269164539cfd57a10e545c1fb3aeb19c711 and contender = 6fa5891e9259e1f68208928895efa72235addb5f. 6fa5891e9259e1f68208928895efa72235addb5f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Failed] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/bbf6f5a0cadd4f75a18d7b539e1f7ccd...475fb2e7ce7d4049a435f845f3e767b3/)
[Failed] [test-mac-arm](https://conbench.ursa.dev/compare/runs/945ac340f4df473286823667c57994cf...04cb5ba6289c436cae8c0407ec90b01e/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/25bf21eff25548979a91aef2f3c168b8...9f0290f1bd6848cbab01d95138e977fb/)
[Failed] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/895f4fd849804960ab3e5769ec47e8d0...c45b2616249841f8a73f42f7d7d70a88/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson closed pull request #12360: MINOR: [R] Update a URL to https
Posted by GitBox <gi...@apache.org>.
nealrichardson closed pull request #12360:
URL: https://github.com/apache/arrow/pull/12360
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] thisisnic commented on a change in pull request #12360: [R] R package URL updates
Posted by GitBox <gi...@apache.org>.
thisisnic commented on a change in pull request #12360:
URL: https://github.com/apache/arrow/pull/12360#discussion_r801074767
##########
File path: r/vignettes/developing.Rmd
##########
@@ -11,8 +11,8 @@ If you're interested in contributing to arrow, this vignette explains our approa
at a high-level. If you're looking for more detailed content, you may want to
look at one of the following links:
-* [setting up a development environment and building the components that make up the Arrow project and R package](https://arrow.apache.org/docs/r/articles/developers/setup.html)
-* [common Arrow dev workflow tasks](https://arrow.apache.org/docs/r/articles/developers/workflow.html)
+* [setting up a development environment and building the components that make up the Arrow project and R package](https://arrow.apache.org/docs/r/articles/developing.html#developer-environment-setup)
+* [common Arrow dev workflow tasks](https://arrow.apache.org/docs/r/articles/developing.html#common-developer-workflow-tasks)
Review comment:
This will be fine for the CRAN checks, but once the pkgdown website is updated, these URLs will just point to the web version of the vignette where technically those sections will no longer exist.
Maybe we want to change "you may want to look at one of the following links" to "please refer to the "Developers" section on our pkgdown site" and then remove those links, though this is still clunky as we can't link to the right URL until after the site is updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #12360: MINOR: [R] Update a URL to https
Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #12360:
URL: https://github.com/apache/arrow/pull/12360#issuecomment-1032897640
Benchmark runs are scheduled for baseline = 11e9f269164539cfd57a10e545c1fb3aeb19c711 and contender = 6fa5891e9259e1f68208928895efa72235addb5f. 6fa5891e9259e1f68208928895efa72235addb5f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/bbf6f5a0cadd4f75a18d7b539e1f7ccd...475fb2e7ce7d4049a435f845f3e767b3/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/945ac340f4df473286823667c57994cf...04cb5ba6289c436cae8c0407ec90b01e/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/25bf21eff25548979a91aef2f3c168b8...9f0290f1bd6848cbab01d95138e977fb/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/895f4fd849804960ab3e5769ec47e8d0...c45b2616249841f8a73f42f7d7d70a88/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12360: MINOR: [R] Update a URL to https
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12360:
URL: https://github.com/apache/arrow/pull/12360#issuecomment-1032897640
Benchmark runs are scheduled for baseline = 11e9f269164539cfd57a10e545c1fb3aeb19c711 and contender = 6fa5891e9259e1f68208928895efa72235addb5f. 6fa5891e9259e1f68208928895efa72235addb5f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/bbf6f5a0cadd4f75a18d7b539e1f7ccd...475fb2e7ce7d4049a435f845f3e767b3/)
[Finished :arrow_down:0.64% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/945ac340f4df473286823667c57994cf...04cb5ba6289c436cae8c0407ec90b01e/)
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/25bf21eff25548979a91aef2f3c168b8...9f0290f1bd6848cbab01d95138e977fb/)
[Finished :arrow_down:0.39% :arrow_up:0.09%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/895f4fd849804960ab3e5769ec47e8d0...c45b2616249841f8a73f42f7d7d70a88/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] dragosmg commented on a change in pull request #12360: [R] R package URL updates
Posted by GitBox <gi...@apache.org>.
dragosmg commented on a change in pull request #12360:
URL: https://github.com/apache/arrow/pull/12360#discussion_r801103496
##########
File path: r/vignettes/developing.Rmd
##########
@@ -11,8 +11,8 @@ If you're interested in contributing to arrow, this vignette explains our approa
at a high-level. If you're looking for more detailed content, you may want to
look at one of the following links:
-* [setting up a development environment and building the components that make up the Arrow project and R package](https://arrow.apache.org/docs/r/articles/developers/setup.html)
-* [common Arrow dev workflow tasks](https://arrow.apache.org/docs/r/articles/developers/workflow.html)
+* [setting up a development environment and building the components that make up the Arrow project and R package](https://arrow.apache.org/docs/r/articles/developing.html#developer-environment-setup)
+* [common Arrow dev workflow tasks](https://arrow.apache.org/docs/r/articles/developing.html#common-developer-workflow-tasks)
Review comment:
The only 2 complaints left are:
```r
> urlchecker::url_check()
! Warning: vignettes/arrow.Rmd:73:8 Moved
gains](http://arrow.apache.org/blog/2019/01/25/r-spark-improvements/).
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
https://arrow.apache.org/blog/2019/01/25/r-spark-improvements/
x Error: README.md:5:75 400: Bad Request
[](https://anaconda.org/conda-forge/r-arrow)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
Not sure what the deal is with the conda one - it seems correct. The spark blog one: the URL is an https, not http.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12360: MINOR: [R] Update a URL to https
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12360:
URL: https://github.com/apache/arrow/pull/12360#issuecomment-1032897640
Benchmark runs are scheduled for baseline = 11e9f269164539cfd57a10e545c1fb3aeb19c711 and contender = 6fa5891e9259e1f68208928895efa72235addb5f. 6fa5891e9259e1f68208928895efa72235addb5f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/bbf6f5a0cadd4f75a18d7b539e1f7ccd...475fb2e7ce7d4049a435f845f3e767b3/)
[Finished :arrow_down:0.64% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/945ac340f4df473286823667c57994cf...04cb5ba6289c436cae8c0407ec90b01e/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/25bf21eff25548979a91aef2f3c168b8...9f0290f1bd6848cbab01d95138e977fb/)
[Finished :arrow_down:0.39% :arrow_up:0.09%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/895f4fd849804960ab3e5769ec47e8d0...c45b2616249841f8a73f42f7d7d70a88/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12360: MINOR: [R] Update a URL to https
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12360:
URL: https://github.com/apache/arrow/pull/12360#issuecomment-1032897640
Benchmark runs are scheduled for baseline = 11e9f269164539cfd57a10e545c1fb3aeb19c711 and contender = 6fa5891e9259e1f68208928895efa72235addb5f. 6fa5891e9259e1f68208928895efa72235addb5f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/bbf6f5a0cadd4f75a18d7b539e1f7ccd...475fb2e7ce7d4049a435f845f3e767b3/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/945ac340f4df473286823667c57994cf...04cb5ba6289c436cae8c0407ec90b01e/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/25bf21eff25548979a91aef2f3c168b8...9f0290f1bd6848cbab01d95138e977fb/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/895f4fd849804960ab3e5769ec47e8d0...c45b2616249841f8a73f42f7d7d70a88/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12360: [R] R package URL updates
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12360:
URL: https://github.com/apache/arrow/pull/12360#issuecomment-1031763050
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW
Opening JIRAs ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12360: MINOR: [R] Update a URL to https
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12360:
URL: https://github.com/apache/arrow/pull/12360#issuecomment-1032897640
Benchmark runs are scheduled for baseline = 11e9f269164539cfd57a10e545c1fb3aeb19c711 and contender = 6fa5891e9259e1f68208928895efa72235addb5f. 6fa5891e9259e1f68208928895efa72235addb5f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/bbf6f5a0cadd4f75a18d7b539e1f7ccd...475fb2e7ce7d4049a435f845f3e767b3/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/945ac340f4df473286823667c57994cf...04cb5ba6289c436cae8c0407ec90b01e/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/25bf21eff25548979a91aef2f3c168b8...9f0290f1bd6848cbab01d95138e977fb/)
[Finished :arrow_down:0.39% :arrow_up:0.09%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/895f4fd849804960ab3e5769ec47e8d0...c45b2616249841f8a73f42f7d7d70a88/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on a change in pull request #12360: [R] R package URL updates
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on a change in pull request #12360:
URL: https://github.com/apache/arrow/pull/12360#discussion_r801101536
##########
File path: r/vignettes/developing.Rmd
##########
@@ -11,8 +11,8 @@ If you're interested in contributing to arrow, this vignette explains our approa
at a high-level. If you're looking for more detailed content, you may want to
look at one of the following links:
-* [setting up a development environment and building the components that make up the Arrow project and R package](https://arrow.apache.org/docs/r/articles/developers/setup.html)
-* [common Arrow dev workflow tasks](https://arrow.apache.org/docs/r/articles/developers/workflow.html)
+* [setting up a development environment and building the components that make up the Arrow project and R package](https://arrow.apache.org/docs/r/articles/developing.html#developer-environment-setup)
+* [common Arrow dev workflow tasks](https://arrow.apache.org/docs/r/articles/developing.html#common-developer-workflow-tasks)
Review comment:
https://arrow.apache.org/docs/r/ is now updated for 7.0.0, so is this change needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12360: MINOR: [R] Update a URL to https
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12360:
URL: https://github.com/apache/arrow/pull/12360#issuecomment-1032897640
Benchmark runs are scheduled for baseline = 11e9f269164539cfd57a10e545c1fb3aeb19c711 and contender = 6fa5891e9259e1f68208928895efa72235addb5f. 6fa5891e9259e1f68208928895efa72235addb5f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/bbf6f5a0cadd4f75a18d7b539e1f7ccd...475fb2e7ce7d4049a435f845f3e767b3/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/945ac340f4df473286823667c57994cf...04cb5ba6289c436cae8c0407ec90b01e/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/25bf21eff25548979a91aef2f3c168b8...9f0290f1bd6848cbab01d95138e977fb/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/895f4fd849804960ab3e5769ec47e8d0...c45b2616249841f8a73f42f7d7d70a88/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] thisisnic commented on a change in pull request #12360: [R] R package URL updates
Posted by GitBox <gi...@apache.org>.
thisisnic commented on a change in pull request #12360:
URL: https://github.com/apache/arrow/pull/12360#discussion_r801074767
##########
File path: r/vignettes/developing.Rmd
##########
@@ -11,8 +11,8 @@ If you're interested in contributing to arrow, this vignette explains our approa
at a high-level. If you're looking for more detailed content, you may want to
look at one of the following links:
-* [setting up a development environment and building the components that make up the Arrow project and R package](https://arrow.apache.org/docs/r/articles/developers/setup.html)
-* [common Arrow dev workflow tasks](https://arrow.apache.org/docs/r/articles/developers/workflow.html)
+* [setting up a development environment and building the components that make up the Arrow project and R package](https://arrow.apache.org/docs/r/articles/developing.html#developer-environment-setup)
+* [common Arrow dev workflow tasks](https://arrow.apache.org/docs/r/articles/developing.html#common-developer-workflow-tasks)
Review comment:
This will be fine for the CRAN checks, but once the pkgdown website is updated, these URLs will just point to the web version of the vignette where technically those sections will no longer exist.
Maybe we want to change "you may want to look at one of the following links" to "please refer to the "Developers" section on our pkgdown site", though this is still clunky as we can't link to the right URL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] dragosmg commented on a change in pull request #12360: [R] R package URL updates
Posted by GitBox <gi...@apache.org>.
dragosmg commented on a change in pull request #12360:
URL: https://github.com/apache/arrow/pull/12360#discussion_r801105486
##########
File path: r/vignettes/developing.Rmd
##########
@@ -11,8 +11,8 @@ If you're interested in contributing to arrow, this vignette explains our approa
at a high-level. If you're looking for more detailed content, you may want to
look at one of the following links:
-* [setting up a development environment and building the components that make up the Arrow project and R package](https://arrow.apache.org/docs/r/articles/developers/setup.html)
-* [common Arrow dev workflow tasks](https://arrow.apache.org/docs/r/articles/developers/workflow.html)
+* [setting up a development environment and building the components that make up the Arrow project and R package](https://arrow.apache.org/docs/r/articles/developing.html#developer-environment-setup)
+* [common Arrow dev workflow tasks](https://arrow.apache.org/docs/r/articles/developing.html#common-developer-workflow-tasks)
Review comment:
Done. Reverted the 2 other changes. Basically this PR will add the letter `s`. 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] dragosmg commented on a change in pull request #12360: [R] R package URL updates
Posted by GitBox <gi...@apache.org>.
dragosmg commented on a change in pull request #12360:
URL: https://github.com/apache/arrow/pull/12360#discussion_r801103496
##########
File path: r/vignettes/developing.Rmd
##########
@@ -11,8 +11,8 @@ If you're interested in contributing to arrow, this vignette explains our approa
at a high-level. If you're looking for more detailed content, you may want to
look at one of the following links:
-* [setting up a development environment and building the components that make up the Arrow project and R package](https://arrow.apache.org/docs/r/articles/developers/setup.html)
-* [common Arrow dev workflow tasks](https://arrow.apache.org/docs/r/articles/developers/workflow.html)
+* [setting up a development environment and building the components that make up the Arrow project and R package](https://arrow.apache.org/docs/r/articles/developing.html#developer-environment-setup)
+* [common Arrow dev workflow tasks](https://arrow.apache.org/docs/r/articles/developing.html#common-developer-workflow-tasks)
Review comment:
The only 2 complaints left are:
```r
> urlchecker::url_check()
! Warning: vignettes/arrow.Rmd:73:8 Moved
gains](http://arrow.apache.org/blog/2019/01/25/r-spark-improvements/).
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
https://arrow.apache.org/blog/2019/01/25/r-spark-improvements/
x Error: README.md:5:75 400: Bad Request
[](https://anaconda.org/conda-forge/r-arrow)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
Not sure what the deal is with the conda one - it is correct. The spark blog one: the URL is an https, not http.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org