You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "mesejo (via GitHub)" <gi...@apache.org> on 2023/08/18 10:43:07 UTC
[GitHub] [arrow-datafusion-python] mesejo commented on issue #322: Merge PyConfig and PySessionConfig
mesejo commented on issue #322:
URL: https://github.com/apache/arrow-datafusion-python/issues/322#issuecomment-1683721883
Hey! I see that there is a [`SessionConfig`](https://github.com/apache/arrow-datafusion/blob/main/datafusion/execution/src/config.rs#L29) in the DataFusion main repo (docs [here](https://docs.rs/datafusion/latest/datafusion/execution/config/struct.SessionConfig.html)), but I could not find a `Config` Class.
So I guess that to solve this issue, we need to:
1. Move the methods that are present in PyConfig but not in PySessionConfig (for example, [from_env](https://github.com/apache/arrow-datafusion-python/blob/main/src/config.rs#L41))
2. Mark PyConfig as deprecated (notifying users of a future deletion)
3. Refactor the tests accordingly
Do we need to do anything else?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org