You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2020/01/31 20:14:35 UTC
[GitHub] [couchdb-documentation] lbboe opened a new pull request #491: Fixes
#479 to add document partitioned DBs + Mango content
lbboe opened a new pull request #491: Fixes #479 to add document partitioned DBs + Mango content
URL: https://github.com/apache/couchdb-documentation/pull/491
## Overview
Per issue #479, update the document partitioned DBs + Mango content. This content is not currently documented.
## GitHub issue number
Issue #479
## Checklist
- [ ] Documentation is written and is accurate;
- [ ] `make check` passes with no errors
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb-documentation] flimzy commented on a change in pull
request #491: Fixes #479 to add document partitioned DBs + Mango content
Posted by GitBox <gi...@apache.org>.
flimzy commented on a change in pull request #491: Fixes #479 to add document partitioned DBs + Mango content
URL: https://github.com/apache/couchdb-documentation/pull/491#discussion_r373675978
##########
File path: src/api/database/find.rst
##########
@@ -943,6 +943,12 @@ built using MapReduce Views.
:query json partial_filter_selector: A :ref:`selector <find/selectors>`
to apply to documents at indexing time, creating a
:ref:`partial index <find/partial_indexes>`. *Optional*
+ :query boolean partitioned: Determines whether a JSON index is partitioned
+ or global. To create a partitioned index, set the ``"partitioned"`` field
+ to ``true``. To create a global index on a partitioned database, specify
+ ``false`` for the ``"partitioned"`` field. If you specify ``true``
+ for the ``"partitioned"`` field on an unpartitioned database, an
+ error occurs.
Review comment:
Is there a default value, or is this value required in all cases?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb-documentation] flimzy commented on a change in pull
request #491: Fixes #479 to add document partitioned DBs + Mango content
Posted by GitBox <gi...@apache.org>.
flimzy commented on a change in pull request #491: Fixes #479 to add document partitioned DBs + Mango content
URL: https://github.com/apache/couchdb-documentation/pull/491#discussion_r373676586
##########
File path: src/api/partitioned-dbs.rst
##########
@@ -194,3 +194,38 @@ See the guide for
],
"total_rows": 4
}
+.. _api/partitioned/find:
+
+``/db/_partition/partition_id/_find``
+=====================================
+
+.. http:get:: /{db}/_partition/{partition_id}/_find
+ :synopsis: Find a partition query by ID
Review comment:
This description seems a bit unclear to me. Is this finding a _partition query_ (if so, what is that?), or is it executing a find query only on a specific partition?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb-documentation] wohali merged pull request #491: Fixes #479
to add document partitioned DBs + Mango content
Posted by GitBox <gi...@apache.org>.
wohali merged pull request #491: Fixes #479 to add document partitioned DBs + Mango content
URL: https://github.com/apache/couchdb-documentation/pull/491
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb-documentation] wohali commented on issue #491: Fixes #479
to add document partitioned DBs + Mango content
Posted by GitBox <gi...@apache.org>.
wohali commented on issue #491: Fixes #479 to add document partitioned DBs + Mango content
URL: https://github.com/apache/couchdb-documentation/pull/491#issuecomment-580949565
@lbboe Thank you for a fast turnaround on this!
Looks like there is a newline error that is preventing this from landing:
```
[2020-01-31T21:29:26.586Z] /home/jenkins/workspace/cm1_CouchDB-Documentation_PR-491@2/src/api/partitioned-dbs.rst
[2020-01-31T21:29:26.586Z] line 232 : last line should ends with newline character
```
If you can add the newline to the end of this file, we can get this merged straight away.
Thanks again!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb-documentation] lbboe commented on issue #491: Fixes #479
to add document partitioned DBs + Mango content
Posted by GitBox <gi...@apache.org>.
lbboe commented on issue #491: Fixes #479 to add document partitioned DBs + Mango content
URL: https://github.com/apache/couchdb-documentation/pull/491#issuecomment-580951229
Here you go, @wohali. Thanks again!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services