You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/04/09 00:32:03 UTC

[GitHub] [pulsar] sijie commented on a change in pull request #3992: Add exclusion for windows c++ compiler

sijie commented on a change in pull request #3992: Add exclusion for windows c++ compiler
URL: https://github.com/apache/pulsar/pull/3992#discussion_r273287483
 
 

 ##########
 File path: pulsar-client-cpp/lib/LogUtils.h
 ##########
 @@ -27,7 +27,11 @@
 
 namespace pulsar {
 
+#if defined _WIN32 || defined _WIN64
 
 Review comment:
   how can we test if this works for windows c++ compiler? can we have a docker based test or vagrant based test?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services