You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Matthew Hatem <mh...@gmail.com> on 2011/08/15 17:08:16 UTC
Re: Review Request: Fix to support for VIEW and VIEW_TARGET in actions
feature
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1201/
-----------------------------------------------------------
(Updated 2011-08-15 15:08:16.073843)
Review request for shindig, Ryan Baxter and Eric Woods.
Summary
-------
The spec indicates that an action can specify the view of the gadget to render and a target location within the container to layout the gadget, when the action is triggered. However this information is never passed to the navigateGadget handler function that the container must implement.
JIRA posted here:
https://issues.apache.org/jira/browse/SHINDIG-1572
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/ConServContainer.js 1149267
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js 1149267
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/constants.js PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/feature.xml 1149267
Diff: https://reviews.apache.org/r/1201/diff
Testing
-------
Passes all JsUnit tests.
Thanks,
Matthew
Re: Review Request: Fix to support for VIEW and VIEW_TARGET in actions
feature
Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1201/#review1456
-----------------------------------------------------------
Ship it!
LGTM small nit around extra spaces in but I removed them before I committed.
Committed revision 1157899.
- Ryan
On 2011-08-15 15:08:16, Matthew Hatem wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1201/
> -----------------------------------------------------------
>
> (Updated 2011-08-15 15:08:16)
>
>
> Review request for shindig, Ryan Baxter and Eric Woods.
>
>
> Summary
> -------
>
> The spec indicates that an action can specify the view of the gadget to render and a target location within the container to layout the gadget, when the action is triggered. However this information is never passed to the navigateGadget handler function that the container must implement.
>
> JIRA posted here:
> https://issues.apache.org/jira/browse/SHINDIG-1572
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/ConServContainer.js 1149267
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js 1149267
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/constants.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/feature.xml 1149267
>
> Diff: https://reviews.apache.org/r/1201/diff
>
>
> Testing
> -------
>
> Passes all JsUnit tests.
>
>
> Thanks,
>
> Matthew
>
>