You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "dmilosevic252 (via GitHub)" <gi...@apache.org> on 2023/09/22 08:24:51 UTC
[GitHub] [tvm] dmilosevic252 opened a new pull request, #15804: [Fix][Unity] Fix TVMError when loading ONNX model with CumSum operator
dmilosevic252 opened a new pull request, #15804:
URL: https://github.com/apache/tvm/pull/15804
Sets the default value 0 for the axis variable, if the value has not been previously set.
This is a code patch for fixing this issue: https://github.com/apache/tvm/pull/15574
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] dmilosevic252 commented on pull request #15804: [Fix][Unity] Fix TVMError when loading ONNX model with CumSum operator
Posted by "dmilosevic252 (via GitHub)" <gi...@apache.org>.
dmilosevic252 commented on PR #15804:
URL: https://github.com/apache/tvm/pull/15804#issuecomment-1733617541
@jikechao Thank you for the feedback! I added a regression test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix][Unity] Fix TVMError when loading ONNX model with CumSum operator [tvm]
Posted by "dmilosevic252 (via GitHub)" <gi...@apache.org>.
dmilosevic252 commented on code in PR #15804:
URL: https://github.com/apache/tvm/pull/15804#discussion_r1344156882
##########
tests/python/frontend/onnx/test_forward.py:
##########
@@ -6629,7 +6651,6 @@ def verify_qlinearconv(
bias=False,
per_channel_quantization=False,
):
-
Review Comment:
The line changes have been reverted. Thank you for the feedback!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix][Unity] Fix TVMError when loading ONNX model with CumSum operator [tvm]
Posted by "Hzfengsy (via GitHub)" <gi...@apache.org>.
Hzfengsy merged PR #15804:
URL: https://github.com/apache/tvm/pull/15804
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] jikechao commented on pull request #15804: [Fix][Unity] Fix TVMError when loading ONNX model with CumSum operator
Posted by "jikechao (via GitHub)" <gi...@apache.org>.
jikechao commented on PR #15804:
URL: https://github.com/apache/tvm/pull/15804#issuecomment-1731091473
@dmilosevic252 Thanks for your fixing. Could you add a regression test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix][Unity] Fix TVMError when loading ONNX model with CumSum operator [tvm]
Posted by "Hzfengsy (via GitHub)" <gi...@apache.org>.
Hzfengsy commented on code in PR #15804:
URL: https://github.com/apache/tvm/pull/15804#discussion_r1344135194
##########
tests/python/frontend/onnx/test_forward.py:
##########
@@ -6629,7 +6651,6 @@ def verify_qlinearconv(
bias=False,
per_channel_quantization=False,
):
-
Review Comment:
Please revert the lines of changes to keep the PR clear :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org