You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Brian Havard <br...@kheldar.apana.org.au> on 2001/05/20 10:02:19 UTC
DAV build
At the moment --enable-mods-shared=most causes mod_dav to get built shared
but mod_dav_fs gets built static. The below change fixes it for me so both
get built shared but I'm not certain it will always be right, especially
considering this isn't the first attempt to fix this....
Index: config6.m4
===================================================================
RCS file: /home/cvs/httpd-2.0/modules/dav/fs/config6.m4,v
retrieving revision 1.3
diff -u -r1.3 config6.m4
--- config6.m4 2001/05/18 20:27:45 1.3
+++ config6.m4 2001/05/20 07:55:57
@@ -7,7 +7,7 @@
if test "$enable_dav" = "no"; then
dav_fs_enable=no
else
- dav_fs_enable="$enable_dav"
+ dav_fs_enable="$dav_enable"
fi
APACHE_MODULE(dav_fs, DAV provider for the filesystem, $dav_fs_objects, , $dav_fs_enable)
--
______________________________________________________________________________
| Brian Havard | "He is not the messiah! |
| brianh@kheldar.apana.org.au | He's a very naughty boy!" - Life of Brian |
------------------------------------------------------------------------------
Re: DAV build
Posted by Greg Stein <gs...@lyra.org>.
On Mon, May 21, 2001 at 02:29:46AM +1000, Brian Havard wrote:
>...
> Nope, that doesn't do it. It doesn't work right if using --enable-dav
> explicitly. Getting the right behaviour in all situations I tested required
> the patch below. Is there any good reason why we can't combine these into one
> module?
They don't combine -- they are two separate modules. One provides DAV
functionality, the other provides the backend repository. At the moment,
there are at least four backends in development that I'm aware of.
>...
> --- config6.m4 2001/05/18 20:27:45 1.3
> +++ config6.m4 2001/05/20 16:27:38
> @@ -7,7 +7,15 @@
> if test "$enable_dav" = "no"; then
> dav_fs_enable=no
> else
> - dav_fs_enable="$enable_dav"
> + dav_fs_enable=most
> +
> + if test -z "$enable_dav_fs"; then
> + if test -z "$enable_dav"; then
> + enable_dav_fs="shared"
> + else
> + enable_dav_fs="$enable_dav"
> + fi
> + fi
> fi
>
> APACHE_MODULE(dav_fs, DAV provider for the filesystem, $dav_fs_objects, , $dav_fs_enable)
Hmm. In that inner block, the hard-coded "shared" doesn't feel right. The
default for shared/non-shared is defined by $module_default. Also, the
variable should probably be dav_fs_enable for passing to the APACHE_MODULE
macro, right?
Looks like I'll have to get in there and start trying the combos...
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
Re: DAV build
Posted by Brian Havard <br...@kheldar.apana.org.au>.
On Sun, 20 May 2001 18:02:19 +1000 (EST), Brian Havard wrote:
>At the moment --enable-mods-shared=most causes mod_dav to get built shared
>but mod_dav_fs gets built static. The below change fixes it for me so both
>get built shared but I'm not certain it will always be right, especially
>considering this isn't the first attempt to fix this....
>
>Index: config6.m4
>===================================================================
>RCS file: /home/cvs/httpd-2.0/modules/dav/fs/config6.m4,v
>retrieving revision 1.3
>diff -u -r1.3 config6.m4
>--- config6.m4 2001/05/18 20:27:45 1.3
>+++ config6.m4 2001/05/20 07:55:57
>@@ -7,7 +7,7 @@
> if test "$enable_dav" = "no"; then
> dav_fs_enable=no
> else
>- dav_fs_enable="$enable_dav"
>+ dav_fs_enable="$dav_enable"
> fi
>
> APACHE_MODULE(dav_fs, DAV provider for the filesystem, $dav_fs_objects, , $dav_fs_enable)
Nope, that doesn't do it. It doesn't work right if using --enable-dav
explicitly. Getting the right behaviour in all situations I tested required
the patch below. Is there any good reason why we can't combine these into one
module? That would simplify things a great deal.
Index: config6.m4
===================================================================
RCS file: /home/cvs/httpd-2.0/modules/dav/fs/config6.m4,v
retrieving revision 1.3
diff -u -r1.3 config6.m4
--- config6.m4 2001/05/18 20:27:45 1.3
+++ config6.m4 2001/05/20 16:27:38
@@ -7,7 +7,15 @@
if test "$enable_dav" = "no"; then
dav_fs_enable=no
else
- dav_fs_enable="$enable_dav"
+ dav_fs_enable=most
+
+ if test -z "$enable_dav_fs"; then
+ if test -z "$enable_dav"; then
+ enable_dav_fs="shared"
+ else
+ enable_dav_fs="$enable_dav"
+ fi
+ fi
fi
APACHE_MODULE(dav_fs, DAV provider for the filesystem, $dav_fs_objects, , $dav_fs_enable)
--
______________________________________________________________________________
| Brian Havard | "He is not the messiah! |
| brianh@kheldar.apana.org.au | He's a very naughty boy!" - Life of Brian |
------------------------------------------------------------------------------