You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2019/07/23 04:43:53 UTC
[GitHub] [hbase] Apache-HBase commented on issue #401: HBASE-22721 Refactor
HBaseFsck: move the inner class out
Apache-HBase commented on issue #401: HBASE-22721 Refactor HBaseFsck: move the inner class out
URL: https://github.com/apache/hbase/pull/401#issuecomment-514051813
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| 0 | reexec | 37 | Docker mode activated. |
||| _ Prechecks _ |
| +1 | dupname | 1 | No case conflicting files found. |
| +1 | hbaseanti | 0 | Patch does not have any anti-patterns. |
| +1 | @author | 0 | The patch does not contain any @author tags. |
| +1 | test4tests | 0 | The patch appears to include 4 new or modified test files. |
||| _ master Compile Tests _ |
| +1 | mvninstall | 271 | master passed |
| +1 | compile | 60 | master passed |
| +1 | checkstyle | 85 | master passed |
| +1 | shadedjars | 276 | branch has no errors when building our shaded downstream artifacts. |
| +1 | javadoc | 34 | master passed |
| 0 | spotbugs | 227 | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 | findbugs | 225 | master passed |
||| _ Patch Compile Tests _ |
| +1 | mvninstall | 249 | the patch passed |
| +1 | compile | 53 | the patch passed |
| +1 | javac | 53 | the patch passed |
| -1 | checkstyle | 80 | hbase-server: The patch generated 34 new + 174 unchanged - 23 fixed = 208 total (was 197) |
| +1 | whitespace | 1 | The patch has no whitespace issues. |
| +1 | shadedjars | 256 | patch has no errors when building our shaded downstream artifacts. |
| +1 | hadoopcheck | 730 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. |
| +1 | javadoc | 32 | the patch passed |
| -1 | findbugs | 245 | hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) |
||| _ Other Tests _ |
| +1 | unit | 7857 | hbase-server in the patch passed. |
| +1 | asflicense | 20 | The patch does not generate ASF License warnings. |
| | | 10827 | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:hbase-server |
| | Should org.apache.hadoop.hbase.util.HbckRegionInfo$OnlineEntry be a _static_ inner class? At HbckRegionInfo.java:inner class? At HbckRegionInfo.java:[lines 346-361] |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-401/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/401 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 83f69176d395 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-401/out/precommit/personality/provided.sh |
| git revision | master / 9615c644f5 |
| Default Java | 1.8.0_181 |
| checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-401/1/artifact/out/diff-checkstyle-hbase-server.txt |
| findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-401/1/artifact/out/new-findbugs-hbase-server.html |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-401/1/testReport/ |
| Max. process+thread count | 4775 (vs. ulimit of 10000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-401/1/console |
| versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
| Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services