[GitHub] mistercrunch commented on a change in pull request #6610: Add support to Apache Drill

[GitBox <gi...@apache.org>]

mistercrunch commented on a change in pull request #6610: Add support to Apache Drill
URL: https://github.com/apache/incubator-superset/pull/6610#discussion_r245886254
 
 

 ##########
 File path: superset/views/core.py
 ##########
 @@ -1560,8 +1560,16 @@ def tables(self, db_id, schema, substr, force_refresh='false'):
             max_tables = max_items * len(table_names) // total_items
             max_views = max_items * len(view_names) // total_items
 
-        table_options = [{'value': tn, 'label': tn}
-                         for tn in table_names[:max_tables]]
+        # Make modifications for Drill
+        # This hack (and it's a total hack) replaces the dot from the file extension
+        # with '@@@' to prevent Superset from misinterpreting the schema
+        if "drill+sadrill" in database.sqlalchemy_uri_decrypted:
 
 Review comment:
   To avoid having `if database.engine == 'some_engine'` all over the codebase, we make sure to keep all of the database engine specific code in `db_engine_specs.py`. We may need to add some new hook in `db_engine_specs.py` to support your use case, though hopefully not a hack...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org