You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Leo Toff (Jira)" <ji...@apache.org> on 2023/11/27 01:06:00 UTC

[jira] [Comment Edited] (CASSANDRA-18806) create README.md for cassandra-accord subproject

    [ https://issues.apache.org/jira/browse/CASSANDRA-18806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17789875#comment-17789875 ] 

Leo Toff edited comment on CASSANDRA-18806 at 11/27/23 1:05 AM:
----------------------------------------------------------------

[~maoling] I've initialized README.md with the following:

 - Intro to Accord

 - Build instructions

 - Maelstrom testing instructions

Some clarifications on why there are other changes besides README.md:

 - RAT (Release Audit Tool) was failing because README.md doesn't include a license header, so I had to exclude the file from RAT

 - Jepsen Maelstrom runner expects an executable script, so I added "server.sh" similar to the Maelstrom Java demo [https://github.com/jepsen-io/maelstrom/tree/main/demo/java]. And I added "build.sh" for completeness.

The code is attached as a patch to this Jira. Let me know what you think. Once given a green light, I'll create a PR.


was (Author: JIRAUSER303078):
[~maoling] I've initialized README.md with the following:

 - Intro to Accord

 - Build instructions

 - Maelstrom testing instructions

Some clarifications on why there are other changes besides README.md:

 - RAT (Release Audit Tool) was failing because README.md doesn't include a license header, so I had to exclude the file from RAT

 - Jepsen Maelstrom runner expects an executable script, so I added "server.sh" similar to [the Maelstrom Java demo|[https://github.com/jepsen-io/maelstrom/tree/main/demo/java].] And I added "build.sh" for completeness.

The code is attached as a patch to this Jira. Let me know what you think. Once given a green light, I'll create a PR.

> create README.md for cassandra-accord subproject
> ------------------------------------------------
>
>                 Key: CASSANDRA-18806
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-18806
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Accord
>            Reporter: Ling Mao
>            Assignee: Leo Toff
>            Priority: Normal
>             Fix For: 5.x
>
>         Attachments: CASSANDRA-18806.txt
>
>
> We should add more descriptions to the cassandra-accord subproject, such as following:
> 1. how to build and run the source code with gradle
> 2. how the codes are organized
> 3. explain the protocal in a more understanding way



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org