You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Stefan Küng <to...@gmail.com> on 2007/09/22 14:57:05 UTC
[PATCH] fix uninitialized return value in svn_client_root_url_from_path
Hi,
If svn_client_root_url_from_path() is called without initializing the
return value first to NULL, the function fails without returning an
error. This is bad.
Attached is a patch which fixes this problem by initializing the return
value first - otherwise the check on line 244 in
subversion/libsvn_client/util.c fails even though it shouldn't.
Stefan
--
___
oo // \\ "De Chelonian Mobile"
(_,\/ \_/ \ TortoiseSVN
\ \_/_\_/> The coolest Interface to (Sub)Version Control
/_/ \_\ http://tortoisesvn.net
Re: [PATCH] fix uninitialized return value in svn_client_root_url_from_path
Posted by "Daniel L. Rall" <dl...@finemaltcoding.com>.
On Sat, 22 Sep 2007, Stefan Küng wrote:
> Stefan Küng wrote:
> >Hi,
> >
> >If svn_client_root_url_from_path() is called without initializing the
> >return value first to NULL, the function fails without returning an
> >error. This is bad.
> >
> >Attached is a patch which fixes this problem by initializing the return
> >value first - otherwise the check on line 244 in
> >subversion/libsvn_client/util.c fails even though it shouldn't.
>
> Sorry for the noise. Just notice that dlr already fixed this in r26742.
Thanks Stefan -- I ran smack into the same bug.
--
Daniel Rall
Re: [PATCH] fix uninitialized return value in svn_client_root_url_from_path
Posted by Stefan Küng <to...@gmail.com>.
Stefan Küng wrote:
> Hi,
>
> If svn_client_root_url_from_path() is called without initializing the
> return value first to NULL, the function fails without returning an
> error. This is bad.
>
> Attached is a patch which fixes this problem by initializing the return
> value first - otherwise the check on line 244 in
> subversion/libsvn_client/util.c fails even though it shouldn't.
Sorry for the noise. Just notice that dlr already fixed this in r26742.
Stefan
--
___
oo // \\ "De Chelonian Mobile"
(_,\/ \_/ \ TortoiseSVN
\ \_/_\_/> The coolest Interface to (Sub)Version Control
/_/ \_\ http://tortoisesvn.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org