[jira] [Commented] (PHOENIX-5243) PhoenixResultSet#next() closes the result set if scanner returns null

["Chinmay Kulkarni (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-5243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16818271#comment-16818271 ] 

Chinmay Kulkarni commented on PHOENIX-5243:
-------------------------------------------

[~swaroopa] Thanks for the patch. Can you please describe how you ran into this issue wherein the ResultSet object continued to be used even after getting a null current row? Brief offline discussion pointed towards something via in SQLline, if so, we may have to make changes in SQLline as well. Please confirm.

Also, in your patch, it would be cleaner if we returned in only 1 spot. We currently already do:
{code:java}
return currentRow != null
{code}
which would suffice for your case as well. We should instead change the existing _else_ condition to
{code:java}
if (currentRow != null) {
    count++;
    .....
}
{code}
this will also ensure that the current functionality of resetting the row projector, etc. would stay unchanged.

> PhoenixResultSet#next() closes the result set if scanner returns null
> ---------------------------------------------------------------------
>
>                 Key: PHOENIX-5243
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5243
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Swaroopa Kadam
>            Assignee: Swaroopa Kadam
>            Priority: Minor
>             Fix For: 4.14.2
>
>         Attachments: PHOENIX-5243.4.x-HBase-1.3.v1.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)