You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@texera.apache.org by GitBox <gi...@apache.org> on 2026/07/09 02:28:01 UTC

[GH] (texera/gh-readonly-queue/main/pr-6048-00572931bf6d5644833efc838b9efa6792c60135): Workflow run "Required Checks" failed!

The GitHub Actions job "Required Checks" on texera.git/gh-readonly-queue/main/pr-6048-00572931bf6d5644833efc838b9efa6792c60135 has failed.
Run started by GitHub user aglinxinyuan (triggered by aglinxinyuan).

Head commit for run:
54b6915325a02bfab8119692b8b37b161fa3d43a / Matthew B. <mg...@uci.edu>
refactor(workflow-operator): extract shared Sklearn descriptor base (#6048)

### What changes were proposed in this PR?
- Add abstract `SklearnModelOpDesc extends PythonOperatorDescriptor`
holding the four shared config fields (`target`, `countVectorizer`,
`text`, `tfidfTransformer`) with their Jackson/JSON-schema annotations,
the two `@JsonIgnore` hooks (`getImportStatements`,
`getUserFriendlyModelName`), and the shared `getOutputSchemas`.
- Change `SklearnClassifierOpDesc` and `SklearnTrainingOpDesc` to extend
the new base, so each keeps only what genuinely differs
(`generatePythonCode`, `operatorInfo`), removing ~50 lines of
copy-pasted, drift-prone code.
- The 51 leaf subclasses inherit the fields unchanged, so the generated
operator schema is identical (no behavior change).
### Any related issues, documentation, discussions?
Closes: #6038
### How was this PR tested?
- Pure refactor with no behavior change; covered by existing
`SklearnOpDescRegistrySpec`, which instantiates a leaf classifier, sets
the inherited `target`/`countVectorizer` fields, and asserts on
`generatePythonCode()` output. Run it in CI via `sbt
"WorkflowOperator/jacoco"`, expect the Sklearn registry specs green.
- Verified locally with `sbt "WorkflowOperator/Test/compile"` (compiles
clean; both descriptors resolve against `SklearnModelOpDesc`).
- Note: `sbt "WorkflowOperator/testOnly *SklearnOpDescRegistrySpec"`
could not run locally because sbt-jacoco offline-instruments the Test
classpath and JaCoCo 0.8.11 fails to instrument the vendored
`JsonSchemaDraft.class` on this JDK (pre-existing tooling issue,
unrelated to this change); the spec runs in CI under the
`WorkflowOperator/jacoco` job.
### Was this PR authored or co-authored using generative AI tooling?
Co-authored with Claude Opus 4.8 in compliance with ASF

---------

Co-authored-by: Xinyuan Lin <xi...@uci.edu>

Report URL: https://github.com/apache/texera/actions/runs/28989396756

With regards,
GitHub Actions via GitBox