You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Brijesh Bhalala <br...@gmail.com> on 2023/02/01 07:02:50 UTC

Review Request 74288: RANGER-4058 : Improvement in Ranger React

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74288/
-----------------------------------------------------------

Review request for ranger, Dhaval Rajpara, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, and Nitin Galave.


Bugs: -, 4058 and RANGER
    https://issues.apache.org/jira/browse/-
    https://issues.apache.org/jira/browse/4058
    https://issues.apache.org/jira/browse/RANGER


Repository: ranger


Description
-------

1)Landing Page :-
    -Scroll for more services at  service list in landing page.
    - Import Module zone filtering services issue solved
    -Sorting the service list by service name.
    -Loader Issue in Import Module in landing page solved.
2)Policy view modal - 
     -Policy Items Permission data minimum width  if 
       permissions are more
3)Policy Logs :-
      - Added Policy ID in Import Delete Policy Logs at Audit 
       Admin Tab


Diffs
-----

  security-admin/src/main/webapp/react-webapp/src/styles/style.css 77ecb7105121cef763545c534c0b96f69d69e07f 
  security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/PolicyLogs.jsx d8b684c47afdc2b2b006f3087b3f17c808d1efbf 
  security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/PolicyViewDetails.jsx accd48b0ca663d5b882350b23e4b0157efa3526b 
  security-admin/src/main/webapp/react-webapp/src/views/SecurityZone/ZoneDisplay.jsx cb9415e7b58ccd39fb0b21bca714b24bdd269a50 
  security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ExportPolicy.jsx 5ce61e73fba39b1c0a992e1c1f0b70bb5085ec7d 
  security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ImportPolicy.jsx e67e88e410a0607c5a7c1b4aa79c8e4737fb94fc 
  security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceDefinition.jsx 15174080bf056c1efd5884f3bb3530b2ac61eeed 
  security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceDefinitions.jsx aa82bbf323a3f6e7aac220db81be2f28f7a62745 


Diff: https://reviews.apache.org/r/74288/diff/1/


Testing
-------

1)Build and Verified Ranger Admin setup with this changes.
2)Verified the following things:-
  1)CRUD Operations for Policy, Services.
  2)Landing Page.
  3)Loader at Import Export Module.


Thanks,

Brijesh Bhalala


Re: Review Request 74288: RANGER-4058 : Improvement in Ranger React

Posted by Mugdha Varadkar <mu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74288/#review225173
-----------------------------------------------------------


Ship it!




Ship It!

- Mugdha Varadkar


On Feb. 3, 2023, 2:02 p.m., Brijesh Bhalala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74288/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2023, 2:02 p.m.)
> 
> 
> Review request for ranger, Dhaval Rajpara, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, and Nitin Galave.
> 
> 
> Bugs: RANGER-4058
>     https://issues.apache.org/jira/browse/RANGER-4058
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> 1)Landing Page :-
>     -Scroll for more services at  service list in landing page.
>     - Import Module zone filtering services issue solved
>     -Sorting the service list by service name.
>     -Loader Issue in Import Module in landing page solved.
> 2)Policy view modal - 
>      -Policy Items Permission data minimum width  if 
>        permissions are more
> 3)Policy Logs :-
>       - Added Policy ID in Import Delete Policy Logs at Audit 
>        Admin Tab
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/webapp/react-webapp/package-lock.json f37a2e2c03d5b0680672681b223fbedd6efc02cc 
>   security-admin/src/main/webapp/react-webapp/src/styles/style.css 77ecb7105121cef763545c534c0b96f69d69e07f 
>   security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/PolicyLogs.jsx d8b684c47afdc2b2b006f3087b3f17c808d1efbf 
>   security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/PolicyViewDetails.jsx accd48b0ca663d5b882350b23e4b0157efa3526b 
>   security-admin/src/main/webapp/react-webapp/src/views/SecurityZone/ZoneDisplay.jsx cb9415e7b58ccd39fb0b21bca714b24bdd269a50 
>   security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ExportPolicy.jsx 5ce61e73fba39b1c0a992e1c1f0b70bb5085ec7d 
>   security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ImportPolicy.jsx e67e88e410a0607c5a7c1b4aa79c8e4737fb94fc 
>   security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceDefinition.jsx 15174080bf056c1efd5884f3bb3530b2ac61eeed 
>   security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceDefinitions.jsx aa82bbf323a3f6e7aac220db81be2f28f7a62745 
>   security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/groups_details/GroupListing.jsx 57eacc8e0e96850b46723070da5fc3408eccc3f0 
> 
> 
> Diff: https://reviews.apache.org/r/74288/diff/2/
> 
> 
> Testing
> -------
> 
> 1)Build and Verified Ranger Admin setup with this changes.
> 2)Verified the following things:-
>   1)CRUD Operations for Policy, Services.
>   2)Landing Page.
>   3)Loader at Import Export Module.
> 
> 
> Thanks,
> 
> Brijesh Bhalala
> 
>


Re: Review Request 74288: RANGER-4058 : Improvement in Ranger React

Posted by Dhaval Rajpara <dh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74288/#review225172
-----------------------------------------------------------


Ship it!




Ship It!

- Dhaval Rajpara


On Feb. 3, 2023, 2:02 p.m., Brijesh Bhalala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74288/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2023, 2:02 p.m.)
> 
> 
> Review request for ranger, Dhaval Rajpara, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, and Nitin Galave.
> 
> 
> Bugs: RANGER-4058
>     https://issues.apache.org/jira/browse/RANGER-4058
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> 1)Landing Page :-
>     -Scroll for more services at  service list in landing page.
>     - Import Module zone filtering services issue solved
>     -Sorting the service list by service name.
>     -Loader Issue in Import Module in landing page solved.
> 2)Policy view modal - 
>      -Policy Items Permission data minimum width  if 
>        permissions are more
> 3)Policy Logs :-
>       - Added Policy ID in Import Delete Policy Logs at Audit 
>        Admin Tab
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/webapp/react-webapp/package-lock.json f37a2e2c03d5b0680672681b223fbedd6efc02cc 
>   security-admin/src/main/webapp/react-webapp/src/styles/style.css 77ecb7105121cef763545c534c0b96f69d69e07f 
>   security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/PolicyLogs.jsx d8b684c47afdc2b2b006f3087b3f17c808d1efbf 
>   security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/PolicyViewDetails.jsx accd48b0ca663d5b882350b23e4b0157efa3526b 
>   security-admin/src/main/webapp/react-webapp/src/views/SecurityZone/ZoneDisplay.jsx cb9415e7b58ccd39fb0b21bca714b24bdd269a50 
>   security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ExportPolicy.jsx 5ce61e73fba39b1c0a992e1c1f0b70bb5085ec7d 
>   security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ImportPolicy.jsx e67e88e410a0607c5a7c1b4aa79c8e4737fb94fc 
>   security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceDefinition.jsx 15174080bf056c1efd5884f3bb3530b2ac61eeed 
>   security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceDefinitions.jsx aa82bbf323a3f6e7aac220db81be2f28f7a62745 
>   security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/groups_details/GroupListing.jsx 57eacc8e0e96850b46723070da5fc3408eccc3f0 
> 
> 
> Diff: https://reviews.apache.org/r/74288/diff/2/
> 
> 
> Testing
> -------
> 
> 1)Build and Verified Ranger Admin setup with this changes.
> 2)Verified the following things:-
>   1)CRUD Operations for Policy, Services.
>   2)Landing Page.
>   3)Loader at Import Export Module.
> 
> 
> Thanks,
> 
> Brijesh Bhalala
> 
>


Re: Review Request 74288: RANGER-4058 : Improvement in Ranger React

Posted by Brijesh Bhalala <br...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74288/
-----------------------------------------------------------

(Updated Feb. 3, 2023, 2:02 p.m.)


Review request for ranger, Dhaval Rajpara, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, and Nitin Galave.


Bugs: RANGER-4058
    https://issues.apache.org/jira/browse/RANGER-4058


Repository: ranger


Description
-------

1)Landing Page :-
    -Scroll for more services at  service list in landing page.
    - Import Module zone filtering services issue solved
    -Sorting the service list by service name.
    -Loader Issue in Import Module in landing page solved.
2)Policy view modal - 
     -Policy Items Permission data minimum width  if 
       permissions are more
3)Policy Logs :-
      - Added Policy ID in Import Delete Policy Logs at Audit 
       Admin Tab


Diffs (updated)
-----

  security-admin/src/main/webapp/react-webapp/package-lock.json f37a2e2c03d5b0680672681b223fbedd6efc02cc 
  security-admin/src/main/webapp/react-webapp/src/styles/style.css 77ecb7105121cef763545c534c0b96f69d69e07f 
  security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/PolicyLogs.jsx d8b684c47afdc2b2b006f3087b3f17c808d1efbf 
  security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/PolicyViewDetails.jsx accd48b0ca663d5b882350b23e4b0157efa3526b 
  security-admin/src/main/webapp/react-webapp/src/views/SecurityZone/ZoneDisplay.jsx cb9415e7b58ccd39fb0b21bca714b24bdd269a50 
  security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ExportPolicy.jsx 5ce61e73fba39b1c0a992e1c1f0b70bb5085ec7d 
  security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ImportPolicy.jsx e67e88e410a0607c5a7c1b4aa79c8e4737fb94fc 
  security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceDefinition.jsx 15174080bf056c1efd5884f3bb3530b2ac61eeed 
  security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceDefinitions.jsx aa82bbf323a3f6e7aac220db81be2f28f7a62745 
  security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/groups_details/GroupListing.jsx 57eacc8e0e96850b46723070da5fc3408eccc3f0 


Diff: https://reviews.apache.org/r/74288/diff/2/

Changes: https://reviews.apache.org/r/74288/diff/1-2/


Testing
-------

1)Build and Verified Ranger Admin setup with this changes.
2)Verified the following things:-
  1)CRUD Operations for Policy, Services.
  2)Landing Page.
  3)Loader at Import Export Module.


Thanks,

Brijesh Bhalala


Re: Review Request 74288: RANGER-4058 : Improvement in Ranger React

Posted by Brijesh Bhalala <br...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74288/
-----------------------------------------------------------

(Updated Feb. 1, 2023, 7:06 a.m.)


Review request for ranger, Dhaval Rajpara, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, and Nitin Galave.


Bugs: RANGER-4058
    https://issues.apache.org/jira/browse/RANGER-4058


Repository: ranger


Description
-------

1)Landing Page :-
    -Scroll for more services at  service list in landing page.
    - Import Module zone filtering services issue solved
    -Sorting the service list by service name.
    -Loader Issue in Import Module in landing page solved.
2)Policy view modal - 
     -Policy Items Permission data minimum width  if 
       permissions are more
3)Policy Logs :-
      - Added Policy ID in Import Delete Policy Logs at Audit 
       Admin Tab


Diffs
-----

  security-admin/src/main/webapp/react-webapp/src/styles/style.css 77ecb7105121cef763545c534c0b96f69d69e07f 
  security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/PolicyLogs.jsx d8b684c47afdc2b2b006f3087b3f17c808d1efbf 
  security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/PolicyViewDetails.jsx accd48b0ca663d5b882350b23e4b0157efa3526b 
  security-admin/src/main/webapp/react-webapp/src/views/SecurityZone/ZoneDisplay.jsx cb9415e7b58ccd39fb0b21bca714b24bdd269a50 
  security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ExportPolicy.jsx 5ce61e73fba39b1c0a992e1c1f0b70bb5085ec7d 
  security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ImportPolicy.jsx e67e88e410a0607c5a7c1b4aa79c8e4737fb94fc 
  security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceDefinition.jsx 15174080bf056c1efd5884f3bb3530b2ac61eeed 
  security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceDefinitions.jsx aa82bbf323a3f6e7aac220db81be2f28f7a62745 


Diff: https://reviews.apache.org/r/74288/diff/1/


Testing
-------

1)Build and Verified Ranger Admin setup with this changes.
2)Verified the following things:-
  1)CRUD Operations for Policy, Services.
  2)Landing Page.
  3)Loader at Import Export Module.


Thanks,

Brijesh Bhalala