You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/02/10 21:06:13 UTC

[GitHub] [druid] clintropolis commented on a change in pull request #10874: Filter unauthorized views in InformationSchema

clintropolis commented on a change in pull request #10874:
URL: https://github.com/apache/druid/pull/10874#discussion_r574075733



##########
File path: sql/src/main/java/org/apache/druid/sql/calcite/schema/InformationSchema.java
##########
@@ -119,12 +122,14 @@
   private final Map<String, Table> tableMap;
   private final AuthorizerMapper authorizerMapper;
   private final String druidSchemaName;
+  private final String viewSchemaName;
 
   @Inject
   public InformationSchema(
       @Named(DruidCalciteSchemaModule.INCOMPLETE_SCHEMA) final SchemaPlus rootSchema,
       final AuthorizerMapper authorizerMapper,
-      @DruidSchemaName String druidSchemaName
+      @DruidSchemaName String druidSchemaName,
+      @ViewSchemaName String viewSchemaName

Review comment:
       I guess `NamedViewSchema` should probably use this injected name instead of its own name, and also `SqlResourceCollectorShuttle` should probably accept it as well since it does for druid schema name.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org