You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by klopfdreh <gi...@git.apache.org> on 2017/08/01 05:40:28 UTC
[GitHub] wicket pull request #226: Allow to set the rel attribute with CssHeaderItem
GitHub user klopfdreh opened a pull request:
https://github.com/apache/wicket/pull/226
Allow to set the rel attribute with CssHeaderItem
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/klopfdreh/wicket rel_attribute_for_cssheaderitem
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/wicket/pull/226.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #226
----
commit 620081b0ae4fdcb09a24e75a8c6173485ab9de94
Author: Tobias Soloschenko <ts...@sapient.com>
Date: 2017-08-01T05:36:15Z
Allow to set the rel attribute with CssHeaderItem
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket issue #226: Allow to set the rel attribute with CssHeaderItem
Posted by klopfdreh <gi...@git.apache.org>.
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/226
Ticket: https://issues.apache.org/jira/browse/WICKET-6433
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket pull request #226: Allow to set the rel attribute with CssHeaderItem
Posted by klopfdreh <gi...@git.apache.org>.
Github user klopfdreh commented on a diff in the pull request:
https://github.com/apache/wicket/pull/226#discussion_r131109389
--- Diff: wicket-core/src/main/java/org/apache/wicket/markup/head/CssHeaderItem.java ---
@@ -169,6 +171,39 @@ public static CssReferenceHeaderItem forReference(ResourceReference reference,
}
/**
+ * Creates a {@link CssReferenceHeaderItem} for the given reference.
+ *
+ * <strong>Warning</strong>: the conditional comments don't work when injected dynamically with
--- End diff --
I just copied the constructor and added the rel parameter. Thats the reason why it is applied there, too. I would just keep it to be backward compatible - the arguments are all Strings, so I have to add a new one behind. 😞
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket issue #226: Allow to set the rel attribute with CssHeaderItem
Posted by martin-g <gi...@git.apache.org>.
Github user martin-g commented on the issue:
https://github.com/apache/wicket/pull/226
Please add a ticket in JIRA. For the changelog. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket issue #226: Allow to set the rel attribute with CssHeaderItem
Posted by klopfdreh <gi...@git.apache.org>.
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/226
Ok I create a JIRA ticket for this! 😃
Thanks for reviewing @martin-g
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket issue #226: Allow to set the rel attribute with CssHeaderItem
Posted by klopfdreh <gi...@git.apache.org>.
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/226
Thanks a lot @martin-g!!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket pull request #226: Allow to set the rel attribute with CssHeaderItem
Posted by martin-g <gi...@git.apache.org>.
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/226#discussion_r131067653
--- Diff: wicket-core/src/main/java/org/apache/wicket/markup/head/CssHeaderItem.java ---
@@ -169,6 +171,39 @@ public static CssReferenceHeaderItem forReference(ResourceReference reference,
}
/**
+ * Creates a {@link CssReferenceHeaderItem} for the given reference.
+ *
+ * <strong>Warning</strong>: the conditional comments don't work when injected dynamically with
--- End diff --
Conditional comments are deprecated since a long time in IE (since 2012, I think).
I think we should not care about them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket issue #226: Allow to set the rel attribute with CssHeaderItem
Posted by klopfdreh <gi...@git.apache.org>.
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/226
Maybe we can create a ticket for this PR to have something for the version changes file
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket pull request #226: Allow to set the rel attribute with CssHeaderItem
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/wicket/pull/226
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---