[GitHub] [iceberg] openinx commented on a change in pull request #3596: Aliyun: Add OSS integration test rule

[GitBox <gi...@apache.org>]

openinx commented on a change in pull request #3596:
URL: https://github.com/apache/iceberg/pull/3596#discussion_r763597025



##########
File path: aliyun/src/test/java/org/apache/iceberg/aliyun/AliyunTestUtility.java
##########
@@ -17,25 +17,31 @@
  * under the License.
  */
 
-package org.apache.iceberg.aliyun.oss;
+package org.apache.iceberg.aliyun;
 
+import org.apache.iceberg.aliyun.oss.AliyunOSSTestRule;
 import org.apache.iceberg.aliyun.oss.mock.AliyunOSSMockRule;
 import org.apache.iceberg.common.DynConstructors;
 import org.apache.iceberg.relocated.com.google.common.base.Strings;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-public class AliyunOSSTestUtility {
-  private static final Logger LOG = LoggerFactory.getLogger(AliyunOSSTestUtility.class);
-  private static final String ALIYUN_TEST_OSS_TEST_RULE_CLASS = "ALIYUN_TEST_OSS_TEST_RULE_CLASS";
+public class AliyunTestUtility {
+  private static final Logger LOG = LoggerFactory.getLogger(AliyunTestUtility.class);
+  private static final String ALIYUN_TEST_OSS_RULE_CLASS = "ALIYUN_TEST_OSS_TEST_RULE_CLASS";

Review comment:
       Why not just use the same name as the assigned value directly ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org