Re: [PR] support protobuf struct type [arrow-go]

["zeroshade (via GitHub)" <gi...@apache.org>]

zeroshade commented on code in PR #206:
URL: https://github.com/apache/arrow-go/pull/206#discussion_r1858807826


##########
arrow/util/protobuf_reflect_test.go:
##########
@@ -97,10 +100,11 @@ func AllTheTypesFixture() Fixture {
 		Any:      anyMsg,
 		//Breaks the test as the Golang maps have a non-deterministic order
 		//SimpleMap:   map[int32]string{99: "Hello", 100: "World", 98: "How", 101: "Are", 1: "You"},
-		SimpleMap:   map[int32]string{99: "Hello"},
-		ComplexMap:  map[string]*util_message.ExampleMessage{"complex": &exampleMsg},
-		SimpleList:  []string{"Hello", "World"},
-		ComplexList: []*util_message.ExampleMessage{&exampleMsg},
+		SimpleMap:     map[int32]string{99: "Hello"},
+		ComplexMap:    map[string]*util_message.ExampleMessage{"complex": &exampleMsg},
+		SimpleList:    []string{"Hello", "World"},
+		ComplexList:   []*util_message.ExampleMessage{&exampleMsg},
+		JsonlikeField: s,

Review Comment:
   doesn't this also need to get added to the expected arrow schema side of things?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org