[GitHub] [inlong] gong commented on a diff in pull request #7536: [INLONG-7535][Manager] Optimize the serializationType setting of PulsarSource to prevent NullPointerException

["gong (via GitHub)" <gi...@apache.org>]

gong commented on code in PR #7536:
URL: https://github.com/apache/inlong/pull/7536#discussion_r1127381991


##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/source/pulsar/PulsarSourceOperator.java:
##########
@@ -131,8 +131,10 @@ public Map<String, List<StreamSource>> getSourcesMap(InlongGroupInfo groupInfo,
             pulsarSource.setAdminUrl(adminUrl);
             pulsarSource.setServiceUrl(serviceUrl);
             pulsarSource.setInlongComponent(true);
-            String serializationType = DataTypeEnum.forType(streamInfo.getDataType()).getType();
-            pulsarSource.setSerializationType(serializationType);
+            if (StringUtils.isNotBlank(streamInfo.getDataType())) {

Review Comment:
   > > @chestnut-c If the dataType was blank, do we need a default value for it?
   > 
   > > PulsarSource
   > 
   > I think the current protocol does not need a default value, but PulsarSource takes values ​​from two places, which leads to the need for fault tolerance
   @chestnut-c @healchow 
   It have a default value.
   ```java
    // if the SerializationType is still null, set it to the CSV
               if (StringUtils.isEmpty(pulsarSource.getSerializationType())) {
                   pulsarSource.setSerializationType(DataTypeEnum.CSV.getType());
               }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org