[GitHub] [hive] kgyrtkirk commented on a change in pull request #2542: [HIVE-25399] Make command splitting consistent between beeline and hi…

[GitBox <gi...@apache.org>]

kgyrtkirk commented on a change in pull request #2542:
URL: https://github.com/apache/hive/pull/2542#discussion_r750438348



##########
File path: cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java
##########
@@ -499,7 +499,10 @@ public CommandProcessorResponse processReader(BufferedReader r) throws IOExcepti
     while ((line = r.readLine()) != null) {
       // Skipping through comments
       if (! line.startsWith("--")) {
-        qsb.append(line + "\n");
+        if (line.contains("--") && line.endsWith(";")) {

Review comment:
       I'm wondering what will happen with:
   ```
   select 'hello -- there' ;
   ```
   I think we only use the `cli` stuff during testing - the `hive` command is launching a `beeline` shell;
   can a user still launch the `hive` cli?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org