You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2020/12/01 13:52:02 UTC
[GitHub] [ignite] ptupitsyn commented on a change in pull request #8483: IGNITE-13496 Java thin: make async API non-blocking with GridNioServer
ptupitsyn commented on a change in pull request #8483:
URL: https://github.com/apache/ignite/pull/8483#discussion_r533421536
##########
File path: modules/core/src/main/java/org/apache/ignite/internal/client/thin/TcpIgniteClient.java
##########
@@ -116,18 +117,23 @@ private TcpIgniteClient(ClientConfiguration cfg) throws ClientException {
ch = new ReliableChannel(chFactory, cfg, binary);
- ch.channelsInit();
+ try {
+ ch.channelsInit();
- ch.addChannelFailListener(() -> metadataHandler.onReconnect());
+ ch.addChannelFailListener(() -> metadataHandler.onReconnect());
- transactions = new TcpClientTransactions(ch, marsh,
- new ClientTransactionConfiguration(cfg.getTransactionConfiguration()));
+ transactions = new TcpClientTransactions(ch, marsh,
+ new ClientTransactionConfiguration(cfg.getTransactionConfiguration()));
- cluster = new ClientClusterImpl(ch, marsh);
+ cluster = new ClientClusterImpl(ch, marsh);
- compute = new ClientComputeImpl(ch, marsh, cluster.defaultClusterGroup());
+ compute = new ClientComputeImpl(ch, marsh, cluster.defaultClusterGroup());
- services = new ClientServicesImpl(ch, marsh, cluster.defaultClusterGroup());
+ services = new ClientServicesImpl(ch, marsh, cluster.defaultClusterGroup());
+ } catch (Exception e) {
Review comment:
Fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org