You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Sven Meier (Created) (JIRA)" <ji...@apache.org> on 2011/11/03 17:53:32 UTC
[jira] [Created] (WICKET-4195) IStringResourceLoader remove one
method
IStringResourceLoader remove one method
---------------------------------------
Key: WICKET-4195
URL: https://issues.apache.org/jira/browse/WICKET-4195
Project: Wicket
Issue Type: Improvement
Components: wicket
Affects Versions: 1.5.2
Reporter: Sven Meier
Priority: Minor
Since WICKET-2910 IStringResourceLoader has two methods with almost identical parameters:
String loadStringResource(Class<?> clazz, String key, Locale locale, String style, String variation);
String loadStringResource(Component component, String key, Locale locale, String style, String variation);
I wonder whether we should remove one of the two, preferrably the first with the class parameter, see attached patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (WICKET-4195) IStringResourceLoader remove one
method
Posted by "Sven Meier (Closed) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sven Meier closed WICKET-4195.
------------------------------
Resolution: Not A Problem
Sorry for the noise, I was just thinking out loud.
> IStringResourceLoader remove one method
> ---------------------------------------
>
> Key: WICKET-4195
> URL: https://issues.apache.org/jira/browse/WICKET-4195
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.5.2
> Reporter: Sven Meier
> Priority: Minor
> Attachments: wicket-4195.patch
>
>
> Since WICKET-2910 IStringResourceLoader has two methods with almost identical parameters:
> String loadStringResource(Class<?> clazz, String key, Locale locale, String style, String variation);
> String loadStringResource(Component component, String key, Locale locale, String style, String variation);
> I wonder whether we should remove one of the two, preferrably the first with the class parameter, see attached patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4195) IStringResourceLoader remove one
method
Posted by "Sven Meier (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sven Meier updated WICKET-4195:
-------------------------------
Attachment: wicket-4195.patch
Removed loadStringResource() with class parameter. I had to adjust a few test but no further problems.
> IStringResourceLoader remove one method
> ---------------------------------------
>
> Key: WICKET-4195
> URL: https://issues.apache.org/jira/browse/WICKET-4195
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.5.2
> Reporter: Sven Meier
> Priority: Minor
> Attachments: wicket-4195.patch
>
>
> Since WICKET-2910 IStringResourceLoader has two methods with almost identical parameters:
> String loadStringResource(Class<?> clazz, String key, Locale locale, String style, String variation);
> String loadStringResource(Component component, String key, Locale locale, String style, String variation);
> I wonder whether we should remove one of the two, preferrably the first with the class parameter, see attached patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4195) IStringResourceLoader remove one
method
Posted by "Igor Vaynberg (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13144784#comment-13144784 ]
Igor Vaynberg commented on WICKET-4195:
---------------------------------------
no problem :)
> IStringResourceLoader remove one method
> ---------------------------------------
>
> Key: WICKET-4195
> URL: https://issues.apache.org/jira/browse/WICKET-4195
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.5.2
> Reporter: Sven Meier
> Priority: Minor
> Attachments: wicket-4195.patch
>
>
> Since WICKET-2910 IStringResourceLoader has two methods with almost identical parameters:
> String loadStringResource(Class<?> clazz, String key, Locale locale, String style, String variation);
> String loadStringResource(Component component, String key, Locale locale, String style, String variation);
> I wonder whether we should remove one of the two, preferrably the first with the class parameter, see attached patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira