You are viewing a plain text version of this content. The canonical link for it is here.
Posted to axis-cvs@ws.apache.org by ba...@apache.org on 2007/09/25 23:18:31 UTC
svn commit: r579386 - in /webservices/axis2/trunk/java/modules:
jaxws/test/org/apache/ws/axis2/tests/
metadata/src/org/apache/axis2/jaxws/description/builder/converter/
metadata/test/org/apache/axis2/jaxws/description/
Author: barrettj
Date: Tue Sep 25 14:18:30 2007
New Revision: 579386
URL: http://svn.apache.org/viewvc?rev=579386&view=rev
Log:
Code cleanup: Remove system.out.prinln; remove commented out code. Note that AnnotationServiceImplDescriptionTests is still commented out per AXIS2-2525
Modified:
webservices/axis2/trunk/java/modules/jaxws/test/org/apache/ws/axis2/tests/EchoServiceImplWithSEI.java
webservices/axis2/trunk/java/modules/metadata/src/org/apache/axis2/jaxws/description/builder/converter/JavaClassToDBCConverter.java
webservices/axis2/trunk/java/modules/metadata/test/org/apache/axis2/jaxws/description/AnnotationServiceImplDescriptionTests.java
Modified: webservices/axis2/trunk/java/modules/jaxws/test/org/apache/ws/axis2/tests/EchoServiceImplWithSEI.java
URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/java/modules/jaxws/test/org/apache/ws/axis2/tests/EchoServiceImplWithSEI.java?rev=579386&r1=579385&r2=579386&view=diff
==============================================================================
--- webservices/axis2/trunk/java/modules/jaxws/test/org/apache/ws/axis2/tests/EchoServiceImplWithSEI.java (original)
+++ webservices/axis2/trunk/java/modules/jaxws/test/org/apache/ws/axis2/tests/EchoServiceImplWithSEI.java Tue Sep 25 14:18:30 2007
@@ -21,12 +21,16 @@
package org.apache.ws.axis2.tests;
import javax.jws.WebService;
+import javax.xml.ws.Holder;
/**
*
*/
@WebService(serviceName = "EchoService", endpointInterface="org.apache.ws.axis2.tests.EchoPort")
public class EchoServiceImplWithSEI {
- // TODO: Test all conditions in JSR-181 spec Sec 3.1 p13
+ // TODO: Test all conditions in JSR-181 spec Sec 3.1 p13
+ public void echo(Holder<String> text) {
+ text.value = "Echo " + text.value;
+ }
}
Modified: webservices/axis2/trunk/java/modules/metadata/src/org/apache/axis2/jaxws/description/builder/converter/JavaClassToDBCConverter.java
URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/java/modules/metadata/src/org/apache/axis2/jaxws/description/builder/converter/JavaClassToDBCConverter.java?rev=579386&r1=579385&r2=579386&view=diff
==============================================================================
--- webservices/axis2/trunk/java/modules/metadata/src/org/apache/axis2/jaxws/description/builder/converter/JavaClassToDBCConverter.java (original)
+++ webservices/axis2/trunk/java/modules/metadata/src/org/apache/axis2/jaxws/description/builder/converter/JavaClassToDBCConverter.java Tue Sep 25 14:18:30 2007
@@ -43,8 +43,11 @@
import org.apache.axis2.jaxws.description.builder.WebServiceAnnot;
import org.apache.axis2.jaxws.description.builder.WebServiceProviderAnnot;
import org.apache.axis2.jaxws.description.builder.WebServiceRefAnnot;
+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
public class JavaClassToDBCConverter {
+ private static final Log log = LogFactory.getLog(JavaClassToDBCConverter.class);
private Class serviceClass;
@@ -85,10 +88,9 @@
}
}
catch (ClassNotFoundException e) {
- // TODO: (JLB) Make this an error log?
- System.out
- .println("Class not found exception caught for class: " + seiClassName);
- e.printStackTrace();
+ if (log.isDebugEnabled()) {
+ log.debug("Class not found exception caught for class: " + seiClassName, e);
+ }
}
}
}
Modified: webservices/axis2/trunk/java/modules/metadata/test/org/apache/axis2/jaxws/description/AnnotationServiceImplDescriptionTests.java
URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/java/modules/metadata/test/org/apache/axis2/jaxws/description/AnnotationServiceImplDescriptionTests.java?rev=579386&r1=579385&r2=579386&view=diff
==============================================================================
--- webservices/axis2/trunk/java/modules/metadata/test/org/apache/axis2/jaxws/description/AnnotationServiceImplDescriptionTests.java (original)
+++ webservices/axis2/trunk/java/modules/metadata/test/org/apache/axis2/jaxws/description/AnnotationServiceImplDescriptionTests.java Tue Sep 25 14:18:30 2007
@@ -25,6 +25,7 @@
import org.apache.axis2.description.Parameter;
import org.apache.log4j.BasicConfigurator;
import org.apache.ws.axis2.tests.EchoServiceImplWithSEI;
+import org.apache.ws.axis2.tests.EchoPort;
import javax.jws.Oneway;
import javax.jws.WebMethod;
@@ -69,8 +70,6 @@
EndpointInterfaceDescription endpointIntfDesc =
endpointDesc[0].getEndpointInterfaceDescription();
assertNotNull(endpointIntfDesc);
- // TODO: (JLB) Remove code
-// assertEquals(EchoPort.class, endpointIntfDesc.getSEIClass());
OperationDescription[] operations =
endpointIntfDesc.getOperationForJavaMethod("badMethodName");
@@ -144,8 +143,6 @@
EndpointInterfaceDescription endpointIntfDesc =
endpointDesc[0].getEndpointInterfaceDescription();
assertNotNull(endpointIntfDesc);
- // TODO: (JLB) Remove code
-// assertEquals(endpointIntfDesc.getSEIClass(), DocLitWrappedProxy.class);
// Test for overloaded methods
// SEI defines two Java methods with this name
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-cvs-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-cvs-help@ws.apache.org