You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Branko Čibej <br...@xbc.nu> on 2004/07/22 13:49:13 UTC
Re: svn commit: r10380 - in trunk: . build
breser@tigris.org wrote:
>Author: breser
>Date: Wed Jul 21 17:21:45 2004
>New Revision: 10380
>
>Modified:
> trunk/build/PrintPath (props changed)
> trunk/build/buildcheck.sh (props changed)
> trunk/build/get-neon-ver.sh (props changed)
> trunk/gen-make.py (props changed)
>Log:
>Correction, everyting that assumes that it can run by doing using the shebang
>line needs to be in LF.
>
>* build/get-neon-ver.sh
>* build/buildcheck.sh
>* build/PrintPath
>* gen-make.py
> Set svn:eol-style to LF.
>
>
I strongly object. This means I can no longer edit these files with a
Windows editor that doesn't understand LF line endings. I understand
you're making these changes to make it easier to generate a ZIP distro
for Windows, but the shebang argument doesn't hold because you don't
acutally have to use it (you can always say, e.g., "sh dist.sh" to avoid
the problems). Even if the shell scripts are expected to be Unix-only,
the Python and Perl scripts definitely aren't.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r10380 - in trunk: . build
Posted by Branko Čibej <br...@xbc.nu>.
Ben Reser wrote:
>On top of that just a couple months ago you argued that we didn't need
>to ship a CRLF zip file becuase any decent editor on Windows understands
>LF line endings.
>
Yes, I know. :-)
> So which is it? Can you deal with LF line endings or
>can't you?
>
>
It's a matter of principle. If we do take the trouble to generate ZIP
distros, then let's do it correctly. Granted, Unix shell scripts can
have LF line endings everywhere; the reasoning is similar as for Windows
DSP files (and templates), for example. However, a Python script that's
intended to be run (and edited) on any platform should have native line
endings (I know for that Python on Unix will happily run scripts with
CRLFs in them). Otherwise we might as well throw away all the eol-style
properties in our repo, for all the good they do.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r10380 - in trunk: . build
Posted by Ben Reser <be...@reser.org>.
On Thu, Jul 22, 2004 at 03:49:13PM +0200, Branko ??ibej wrote:
> I strongly object. This means I can no longer edit these files with a
> Windows editor that doesn't understand LF line endings. I understand
> you're making these changes to make it easier to generate a ZIP distro
> for Windows, but the shebang argument doesn't hold because you don't
> acutally have to use it (you can always say, e.g., "sh dist.sh" to avoid
> the problems). Even if the shell scripts are expected to be Unix-only,
> the Python and Perl scripts definitely aren't.
Even if I use sh autogen.sh (incidentally dist.sh isn't at issue here and I
didn't change it, it's not run by itself and is running before the
export that makes CRLF files is run), this won't be fixed. autogen.sh
and other scripts call even more scripts and presume that the shebang
line will do the invocation. We could fix that but it still wouldn't
fix our problem.
The shell scripts have to be in LF, not just started with an explict
command because bash treats \r as a valid char and passes it onto the
command line. My only other option was to recode the files in the
dist.sh script to LF before generating the zip file. But that seems
really silly when there's no reason for these files to be in CRLF anyway
as far as I can see.
On top of that just a couple months ago you argued that we didn't need
to ship a CRLF zip file becuase any decent editor on Windows understands
LF line endings. So which is it? Can you deal with LF line endings or
can't you?
http://www.contactor.se/~dast/svn/archive-2004-05/1180.shtml
I didn't change any Perl scripts. The only things I changed were a
couple of shell scripts that wouldn't even run on Windows and
gen-make.py. I probably can change gen-make.py back to native and use
an explicit path to run it. If that fixes it I'll change that back.
But I don't see the point in changing the shell scripts that don't even
run on Windows back to native.
--
Ben Reser <be...@reser.org>
http://ben.reser.org
"Conscience is the inner voice which warns us somebody may be looking."
- H.L. Mencken
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r10380 - in trunk: . build
Posted by Max Bowsher <ma...@ukf.net>.
Branko ÄOibej wrote:
> breser@tigris.org wrote:
>
>> Author: breser
>> Date: Wed Jul 21 17:21:45 2004
>> New Revision: 10380
>>
>> Modified:
>> trunk/build/PrintPath (props changed)
>> trunk/build/buildcheck.sh (props changed)
>> trunk/build/get-neon-ver.sh (props changed)
>> trunk/gen-make.py (props changed)
>> Log:
>> Correction, everyting that assumes that it can run by doing using the
shebang
>> line needs to be in LF.
>>
>> * build/get-neon-ver.sh
>> * build/buildcheck.sh
>> * build/PrintPath
>> * gen-make.py
>> Set svn:eol-style to LF.
>>
>>
> I strongly object. This means I can no longer edit these files with a
> Windows editor that doesn't understand LF line endings. I understand
> you're making these changes to make it easier to generate a ZIP distro
> for Windows, but the shebang argument doesn't hold because you don't
> acutally have to use it (you can always say, e.g., "sh dist.sh" to avoid
> the problems). Even if the shell scripts are expected to be Unix-only,
> the Python and Perl scripts definitely aren't.
Sounds like dist.sh needs to be generating temporary LF-ized copies for it's
own local use, not forcing LF *everywhere* for these scripts.
Max.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org