[geode] branch develop updated: GEODE-3449: Fix flakiness in ConnectCommandWithSSLTest

[js...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

jstewart pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/geode.git


The following commit(s) were added to refs/heads/develop by this push:
     new a891ac4  GEODE-3449: Fix flakiness in ConnectCommandWithSSLTest
a891ac4 is described below

commit a891ac4494f80e3f6d4107f77e4754263980a86e
Author: Jared Stewart <js...@pivotal.io>
AuthorDate: Thu Sep 7 15:19:06 2017 -0700

    GEODE-3449: Fix flakiness in ConnectCommandWithSSLTest
---
 .../management/internal/cli/commands/IndexCommandsDUnitTest.java    | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/IndexCommandsDUnitTest.java b/geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/IndexCommandsDUnitTest.java
index 794c588..a4d3f6a 100644
--- a/geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/IndexCommandsDUnitTest.java
+++ b/geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/IndexCommandsDUnitTest.java
@@ -21,6 +21,7 @@ import static org.junit.Assert.assertTrue;
 import java.util.Properties;
 
 import org.junit.Before;
+import org.junit.ClassRule;
 import org.junit.Rule;
 import org.junit.Test;
 import org.junit.experimental.categories.Category;
@@ -35,6 +36,7 @@ import org.apache.geode.management.internal.cli.domain.Stock;
 import org.apache.geode.management.internal.cli.i18n.CliStrings;
 import org.apache.geode.management.internal.cli.result.CommandResult;
 import org.apache.geode.management.internal.cli.util.CommandStringBuilder;
+import org.apache.geode.test.dunit.rules.CleanupDUnitVMsRule;
 import org.apache.geode.test.dunit.rules.GfshShellConnectionRule;
 import org.apache.geode.test.dunit.rules.LocatorServerStartupRule;
 import org.apache.geode.test.dunit.rules.MemberVM;
@@ -42,6 +44,10 @@ import org.apache.geode.test.junit.categories.DistributedTest;
 
 @Category(DistributedTest.class)
 public class IndexCommandsDUnitTest {
+  // This test seemed to be leaving behind state that caused ConnectCommandWithSSLTest to fail if it
+  // was run afterwards. So, this rule ensures we leave behind a clean state.
+  @ClassRule
+  public static CleanupDUnitVMsRule cleanupDUnitVMsRule = new CleanupDUnitVMsRule();
 
   @Rule
   public GfshShellConnectionRule gfsh = new GfshShellConnectionRule();

-- 
To stop receiving notification emails like this one, please contact
['"commits@geode.apache.org" <co...@geode.apache.org>'].