You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/12/15 15:40:03 UTC

[GitHub] [flink] gyfora commented on a diff in pull request #21515: [FLINK-30429][client] Fix IllegalArgumentException when no argument in flink executable

gyfora commented on code in PR #21515:
URL: https://github.com/apache/flink/pull/21515#discussion_r1049796201


##########
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java:
##########
@@ -1149,6 +1150,11 @@ public int parseAndRun(String[] args) {
 
     /** Submits the job based on the arguments. */
     public static void main(final String[] args) {
+        System.exit(mainInternal(args));

Review Comment:
   We need to change this to
   ```
    int retCode = 31;
    try {
    retCode = mainInternal();
   } finallly{System.exit(retCode)}
   
   to preserve the original behavior I think.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org