[GitHub] [arrow-datafusion] crepererum commented on a diff in pull request #6138: feat: concurrent physical planning

["crepererum (via GitHub)" <gi...@apache.org>]

crepererum commented on code in PR #6138:
URL: https://github.com/apache/arrow-datafusion/pull/6138#discussion_r1183448251


##########
datafusion/core/src/physical_plan/planner.rs:
##########
@@ -929,10 +972,11 @@ impl DefaultPhysicalPlanner {
                     }
 
                     // All equi-join keys are columns now, create physical join plan
+                    let mut left_right = self.create_initial_plan_multi([left.as_ref(), right.as_ref()], session_state).await?;

Review Comment:
   and if it doesn't match, what do you do then? `create_initial_plan_multi` has the rule "N in, N out" and hence unwrapping is totally legit here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org