You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@arrow.apache.org by "Yibo Cai (Jira)" <ji...@apache.org> on 2022/03/09 00:55:00 UTC

[jira] [Resolved] (ARROW-15854) [C++] Refine csv writer - populate columns in normal order

     [ https://issues.apache.org/jira/browse/ARROW-15854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Yibo Cai resolved ARROW-15854.
------------------------------
    Fix Version/s: 8.0.0
       Resolution: Fixed

Issue resolved by pull request 12574
[https://github.com/apache/arrow/pull/12574]

> [C++] Refine csv writer - populate columns in normal order
> ----------------------------------------------------------
>
>                 Key: ARROW-15854
>                 URL: https://issues.apache.org/jira/browse/ARROW-15854
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++
>            Reporter: Yibo Cai
>            Assignee: Yibo Cai
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 8.0.0
>
>          Time Spent: 3h 50m
>  Remaining Estimate: 0h
>
> CSV writer populates columns in reverse order, each row is constructed from last cell to first cell.
> Populating columns in normal order makes the code easier to follow, and offers better optimization chances. E.g., EscapeReverse [1] is the hotspot for quoted string benchmark, it's hard to improve if chars are scanned in reverse order, but may benefit from simd if scanned in normal order.
> [1] https://github.com/apache/arrow/blob/master/cpp/src/arrow/csv/writer.cc#L141-L150



--
This message was sent by Atlassian Jira
(v8.20.1#820001)