You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2023/01/05 13:52:41 UTC
[GitHub] [beam] fernando-wizeline opened a new pull request, #23115: GA Migration PostCommit Java Examples Direct, Flink, Spark, Hadoop Versions
fernando-wizeline opened a new pull request, #23115:
URL: https://github.com/apache/beam/pull/23115
As part of the migration of Precommit and Postcommit Jobs from Jenkins to GA in self-hosted runners, this PR contains:
Migrated workflow [job-postcommit-java-examples-direct.yml](https://github.com/fernando-wizeline/beam/blob/gam-postcommit-java-examples-direct-flink-spark/.github/workflows/job-postcommit-java-examples-direct.yml)
Migrated workflow [job-postcommit-java-examples-flink.yml](https://github.com/fernando-wizeline/beam/blob/gam-postcommit-java-examples-direct-flink-spark/.github/workflows/job-postcommit-java-examples-flink.yml)
Migrated workflow [job-postcommit-java-examples-spark.yml](https://github.com/fernando-wizeline/beam/blob/gam-postcommit-java-examples-direct-flink-spark/.github/workflows/job-postcommit-java-examples-spark.yml)
Migrated workflow [job-postcommit-java-hadoop-versions.yml](https://github.com/fernando-wizeline/beam/blob/gam-postcommit-java-examples-direct-flink-spark/.github/workflows/job-postcommit-java-hadoop-versions.yml)
The migrated workflow was removed from [.test-infra/jenkins/README.md](https://github.com/fernando-wizeline/beam/blob/gam-postcommit-java-examples-direct-flink-spark/.test-infra/jenkins/README.md) and added to [CI.md](https://github.com/fernando-wizeline/beam/blob/gam-postcommit-java-examples-direct-flink-spark/CI.md)
DO NOT MERGE until the effort to use self-hosted runners is completed https://github.com/apache/beam/pull/22703
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] closed pull request #23115: GA Migration PostCommit Java Examples Direct, Flink, Spark, Hadoop Versions
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #23115: GA Migration PostCommit Java Examples Direct, Flink, Spark, Hadoop Versions
URL: https://github.com/apache/beam/pull/23115
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on a diff in pull request #23115: GA Migration PostCommit Java Examples Direct, Flink, Spark, Hadoop Versions
Posted by GitBox <gi...@apache.org>.
damccorm commented on code in PR #23115:
URL: https://github.com/apache/beam/pull/23115#discussion_r997391979
##########
.github/workflows/job-postcommit-java-examples-spark.yml:
##########
@@ -0,0 +1,76 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# To learn more about GitHub Actions in Apache Beam check the CI.md
+
+# Runs PostCommit Java Examples Spark via cron and on push to master
+
+name: PostCommit Java Examples Spark
+
+on:
+ workflow_dispatch:
+ schedule:
+ - cron: '0 */6 * * *'
+ push:
+ branches: ['master', 'release-*']
+ tags: ['v*']
+permissions: read-all
+
+jobs:
+ set-properties:
+ runs-on: [self-hosted, ubuntu-20.04]
+ outputs:
+ properties: ${{ steps.test-properties.outputs.properties }}
+ steps:
+ - name: Checkout code
+ uses: actions/checkout@v3
+ with:
+ persist-credentials: false
+ submodules: false
+ - id: test-properties
+ uses: ./.github/actions/setup-default-test-properties
+
+ postcommit-java-examples-spark:
+ needs: set-properties
+ name: Run PostCommit Java Examples Spark
+ runs-on: [self-hosted, ubuntu-20.04]
+ strategy:
+ fail-fast: false
+ matrix: #JDK17 execution will fail due to new access policies applied to the core JDK libraries starting at JDK 16.
+ java: ${{fromJson(needs.set-properties.outputs.properties).JavaTestProperties.SUPPORTED_VERSIONS}}
+ spark: ${{fromJson(needs.set-properties.outputs.properties).JavaTestProperties.SPARK_VERSIONS}}
+ exclude:
+ - java: "11"
+ spark: "2"
Review Comment:
Yep - just something like `Spark v2 dropped support for JDK9+` is great, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23115: GA Migration PostCommit Java Examples Direct, Flink, Spark, Hadoop Versions
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23115:
URL: https://github.com/apache/beam/pull/23115#issuecomment-1372170992
This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on a diff in pull request #23115: GA Migration PostCommit Java Examples Direct, Flink, Spark, Hadoop Versions
Posted by GitBox <gi...@apache.org>.
damccorm commented on code in PR #23115:
URL: https://github.com/apache/beam/pull/23115#discussion_r997292939
##########
.github/workflows/job-postcommit-java-examples-spark.yml:
##########
@@ -0,0 +1,76 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# To learn more about GitHub Actions in Apache Beam check the CI.md
+
+# Runs PostCommit Java Examples Spark via cron and on push to master
+
+name: PostCommit Java Examples Spark
+
+on:
+ workflow_dispatch:
+ schedule:
+ - cron: '0 */6 * * *'
+ push:
+ branches: ['master', 'release-*']
+ tags: ['v*']
+permissions: read-all
+
+jobs:
+ set-properties:
+ runs-on: [self-hosted, ubuntu-20.04]
+ outputs:
+ properties: ${{ steps.test-properties.outputs.properties }}
+ steps:
+ - name: Checkout code
+ uses: actions/checkout@v3
+ with:
+ persist-credentials: false
+ submodules: false
+ - id: test-properties
+ uses: ./.github/actions/setup-default-test-properties
+
+ postcommit-java-examples-spark:
+ needs: set-properties
+ name: Run PostCommit Java Examples Spark
+ runs-on: [self-hosted, ubuntu-20.04]
+ strategy:
+ fail-fast: false
+ matrix: #JDK17 execution will fail due to new access policies applied to the core JDK libraries starting at JDK 16.
+ java: ${{fromJson(needs.set-properties.outputs.properties).JavaTestProperties.SUPPORTED_VERSIONS}}
+ spark: ${{fromJson(needs.set-properties.outputs.properties).JavaTestProperties.SPARK_VERSIONS}}
+ exclude:
+ - java: "11"
+ spark: "2"
Review Comment:
Sorry to be pedantic, but could you please add some more detail here? Compatibility issues doesn't really tell me much about what the problem is
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on a diff in pull request #23115: GA Migration PostCommit Java Examples Direct, Flink, Spark, Hadoop Versions
Posted by GitBox <gi...@apache.org>.
damccorm commented on code in PR #23115:
URL: https://github.com/apache/beam/pull/23115#discussion_r995809973
##########
.github/workflows/job-postcommit-java-examples-spark.yml:
##########
@@ -0,0 +1,76 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# To learn more about GitHub Actions in Apache Beam check the CI.md
+
+# Runs PostCommit Java Examples Spark via cron and on push to master
+
+name: PostCommit Java Examples Spark
+
+on:
+ workflow_dispatch:
+ schedule:
+ - cron: '0 */6 * * *'
+ push:
+ branches: ['master', 'release-*']
+ tags: ['v*']
+permissions: read-all
+
+jobs:
+ set-properties:
+ runs-on: [self-hosted, ubuntu-20.04]
+ outputs:
+ properties: ${{ steps.test-properties.outputs.properties }}
+ steps:
+ - name: Checkout code
+ uses: actions/checkout@v3
+ with:
+ persist-credentials: false
+ submodules: false
+ - id: test-properties
+ uses: ./.github/actions/setup-default-test-properties
+
+ postcommit-java-examples-spark:
+ needs: set-properties
+ name: Run PostCommit Java Examples Spark
+ runs-on: [self-hosted, ubuntu-20.04]
+ strategy:
+ fail-fast: false
+ matrix: #JDK17 execution will fail due to new access policies applied to the core JDK libraries starting at JDK 16.
+ java: ${{fromJson(needs.set-properties.outputs.properties).JavaTestProperties.SUPPORTED_VERSIONS}}
+ spark: ${{fromJson(needs.set-properties.outputs.properties).JavaTestProperties.SPARK_VERSIONS}}
+ exclude:
+ - java: "11"
+ spark: "2"
Review Comment:
Is this excluded for the same reason as 17? If not, please comment to explain
##########
.github/workflows/job-postcommit-java-hadoop-versions.yml:
##########
@@ -0,0 +1,75 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# To learn more about GitHub Actions in Apache Beam check the CI.md
+
+# Runs PostCommit Java Hadoop Versions via cron and on push to master
+
+name: PostCommit Java Hadoop Versions
+
+on:
+ workflow_dispatch:
+ schedule:
+ - cron: '0 */6 * * *'
+ push:
+ branches: ['master', 'release-*']
+ tags: ['v*']
+permissions: read-all
+
+jobs:
+ set-properties:
+ runs-on: [self-hosted, ubuntu-20.04]
+ outputs:
+ properties: ${{ steps.test-properties.outputs.properties }}
+ steps:
+ - name: Checkout code
+ uses: actions/checkout@v3
+ with:
+ persist-credentials: false
+ submodules: false
+ - id: test-properties
+ uses: ./.github/actions/setup-default-test-properties
+
+ postcommit-java-hadoop-versions:
+ needs: set-properties
+ name: Run PostCommit Java Hadoop Versions
+ runs-on: [self-hosted, ubuntu-20.04]
+ strategy:
+ fail-fast: false
+ matrix:
+ java: ${{fromJson(needs.set-properties.outputs.properties).JavaTestProperties.SUPPORTED_VERSIONS}}
+ exclude:
+ - java: "11"
+ - java: "17"
Review Comment:
Please add a comment explaining why these are excluded + linking to the issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm closed pull request #23115: GA Migration PostCommit Java Examples Direct, Flink, Spark, Hadoop Versions
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm closed pull request #23115: GA Migration PostCommit Java Examples Direct, Flink, Spark, Hadoop Versions
URL: https://github.com/apache/beam/pull/23115
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23115: GA Migration PostCommit Java Examples Direct, Flink, Spark, Hadoop Versions
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23115:
URL: https://github.com/apache/beam/pull/23115#issuecomment-1367294578
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] fernando-wizeline commented on a diff in pull request #23115: GA Migration PostCommit Java Examples Direct, Flink, Spark, Hadoop Versions
Posted by GitBox <gi...@apache.org>.
fernando-wizeline commented on code in PR #23115:
URL: https://github.com/apache/beam/pull/23115#discussion_r997330622
##########
.github/workflows/job-postcommit-java-examples-spark.yml:
##########
@@ -0,0 +1,76 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# To learn more about GitHub Actions in Apache Beam check the CI.md
+
+# Runs PostCommit Java Examples Spark via cron and on push to master
+
+name: PostCommit Java Examples Spark
+
+on:
+ workflow_dispatch:
+ schedule:
+ - cron: '0 */6 * * *'
+ push:
+ branches: ['master', 'release-*']
+ tags: ['v*']
+permissions: read-all
+
+jobs:
+ set-properties:
+ runs-on: [self-hosted, ubuntu-20.04]
+ outputs:
+ properties: ${{ steps.test-properties.outputs.properties }}
+ steps:
+ - name: Checkout code
+ uses: actions/checkout@v3
+ with:
+ persist-credentials: false
+ submodules: false
+ - id: test-properties
+ uses: ./.github/actions/setup-default-test-properties
+
+ postcommit-java-examples-spark:
+ needs: set-properties
+ name: Run PostCommit Java Examples Spark
+ runs-on: [self-hosted, ubuntu-20.04]
+ strategy:
+ fail-fast: false
+ matrix: #JDK17 execution will fail due to new access policies applied to the core JDK libraries starting at JDK 16.
+ java: ${{fromJson(needs.set-properties.outputs.properties).JavaTestProperties.SUPPORTED_VERSIONS}}
+ spark: ${{fromJson(needs.set-properties.outputs.properties).JavaTestProperties.SPARK_VERSIONS}}
+ exclude:
+ - java: "11"
+ spark: "2"
Review Comment:
> Sorry to be pedantic, but could you please add some more detail here? Compatibility issues doesn't really tell me much about what the problem is
Oh, no worries, Danny!
About the compatibility issues, Spark v2 dropped support for JDK9+. Spark v3 does work with JDK9+. This thread goes into further detail: https://issues.apache.org/jira/browse/SPARK-24421
Should I add the comment mentioning that?
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23115: GA Migration PostCommit Java Examples Direct, Flink, Spark, Hadoop Versions
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23115:
URL: https://github.com/apache/beam/pull/23115#issuecomment-1458113388
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org