[GitHub] [pulsar] TakaHiR07 commented on a diff in pull request #16792: [improve][broker] enhance grant permission module to reduce zk metadata

[GitBox <gi...@apache.org>]

TakaHiR07 commented on code in PR #16792:
URL: https://github.com/apache/pulsar/pull/16792#discussion_r996724004


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java:
##########
@@ -273,6 +273,24 @@ protected CompletableFuture<Map<String, Set<AuthAction>>> internalGetPermissions
                         }
                     }
                 }
+
+                // If topic is partitioned, add based topic permission

Review Comment:
   @michaeljmarshall Is your idea the same as I described in  https://github.com/apache/pulsar/pull/16792#issuecomment-1219114676 ?? That's what I thought at the beginning, marked as plan 1.
   
   plan 2 is described in https://github.com/apache/pulsar/pull/16792#issue-1317797371, this one is designed based on the idea of @nodece .
   
   Both of the two plan can enhance.  I think plan 1 would have better compatibility with previous version, while plan 2 would have cleaner permission record.
   
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org