[GitHub] chenboat commented on issue #3877: Pinot controller side change to enhance LLC segment metadata upload.

[GitBox <gi...@apache.org>]

chenboat commented on issue #3877: Pinot controller side change to enhance LLC segment metadata upload.
URL: https://github.com/apache/incubator-pinot/pull/3877#issuecomment-468504589
 
 
   > Please note any manual testing you have done in the PR.
   > Here is the test I would suggest. Run LLRealtimeClusterIntegration test in debug mode on your IDE, and issue manual curl calls to start/upload-data and end commit with metadata. Also, if you modify segmentCommit end point, then test that as well the same way.
   > 
   > These tests will make sure that before we add the server side, the code we have on the controller work right.
   > 
   > When we add the server side, we should add integration tests for the whole package.
   > 
   > thanks
   
   I rely on two integration tests: **LLCRealtimeClusterIntegrationTest** and **LLCRealtimeClusterSplitCommitIntegrationTest** which covers segmentCommit and segmentCommitEnd http rest points. For extra safety I used debug modes to check the metadata extraction and it looks good.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org