You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/12/04 18:17:12 UTC

[GitHub] [iceberg] jackye1995 commented on a change in pull request #1872: Core: add contains_nan to field_summary

jackye1995 commented on a change in pull request #1872:
URL: https://github.com/apache/iceberg/pull/1872#discussion_r536288481



##########
File path: core/src/main/java/org/apache/iceberg/GenericPartitionFieldSummary.java
##########
@@ -136,8 +144,10 @@ public Object get(int i) {
       case 0:
         return containsNull;
       case 1:
-        return lowerBound();
+        return containsNaN;

Review comment:
       have we made sure changing the position is backwards compatible?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org